From: Ethan Furman <ethan@stoneleaf.us>
Date: Sat, 10 Aug 2013 20:07:49 +0000 (-0700)
Subject: Close #18693: __dir__ removed from Enum; help() now helpful.
X-Git-Tag: v3.4.0a2~256
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=53f58dbd122676c1408b3c95c1630028cc1a0e05;p=python

Close #18693: __dir__ removed from Enum; help() now helpful.
---

diff --git a/Lib/enum.py b/Lib/enum.py
index 34eb7b87f6..dc9701750c 100644
--- a/Lib/enum.py
+++ b/Lib/enum.py
@@ -223,9 +223,6 @@ class EnumMeta(type):
     def __contains__(cls, member):
         return isinstance(member, cls) and member.name in cls._member_map_
 
-    def __dir__(self):
-        return ['__class__', '__doc__', '__members__'] + self._member_names_
-
     @property
     def __members__(cls):
         """Returns a mapping of member name->value.
@@ -433,9 +430,6 @@ class Enum(metaclass=EnumMeta):
     def __str__(self):
         return "%s.%s" % (self.__class__.__name__, self._name_)
 
-    def __dir__(self):
-        return (['__class__', '__doc__', 'name', 'value'])
-
     def __eq__(self, other):
         if type(other) is self.__class__:
             return self is other
diff --git a/Lib/test/test_enum.py b/Lib/test/test_enum.py
index b959e9712f..751fd56fd7 100644
--- a/Lib/test/test_enum.py
+++ b/Lib/test/test_enum.py
@@ -78,21 +78,6 @@ class TestEnum(unittest.TestCase):
     def test_intenum_value(self):
         self.assertEqual(IntStooges.CURLY.value, 2)
 
-    def test_dir_on_class(self):
-        Season = self.Season
-        self.assertEqual(
-            set(dir(Season)),
-            set(['__class__', '__doc__', '__members__',
-                'SPRING', 'SUMMER', 'AUTUMN', 'WINTER']),
-            )
-
-    def test_dir_on_item(self):
-        Season = self.Season
-        self.assertEqual(
-            set(dir(Season.WINTER)),
-            set(['__class__', '__doc__', 'name', 'value']),
-            )
-
     def test_enum(self):
         Season = self.Season
         lst = list(Season)