From: Aaron Ballman <aaron@aaronballman.com>
Date: Fri, 22 Aug 2014 13:26:37 +0000 (+0000)
Subject: Fixing MSVC warning: "warning C4373: 'blah': virtual function overrides 'blah', previ... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=53c7267c0c8a85fc7039daf1d0eef44f2e46ce79;p=clang

Fixing MSVC warning: "warning C4373: 'blah': virtual function overrides 'blah', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers."

This warning is basically useless because the "previous versions" being referred to is MSVC 2005 and earlier, and we obviously do not care about them. However, this warning isn't particularly chatty (I don't recall ever seeing it previously), and it has the opportunity to point out cases where the cv-qualifiers differ unintentionally (like this case), so I am leaving it enabled for now.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216267 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp
index 2e65589722..4998ca3883 100644
--- a/lib/Basic/Targets.cpp
+++ b/lib/Basic/Targets.cpp
@@ -4146,8 +4146,7 @@ public:
     return R;
   }
   bool
-  validateConstraintModifier(StringRef Constraint, const char Modifier,
-                             unsigned Size,
+  validateConstraintModifier(StringRef Constraint, char Modifier, unsigned Size,
                              std::string &SuggestedModifier) const override {
     bool isOutput = (Constraint[0] == '=');
     bool isInOut = (Constraint[0] == '+');
@@ -4595,8 +4594,7 @@ public:
   }
 
   bool
-  validateConstraintModifier(StringRef Constraint, const char Modifier,
-                             unsigned Size,
+  validateConstraintModifier(StringRef Constraint, char Modifier, unsigned Size,
                              std::string &SuggestedModifier) const override {
     // Strip off constraint modifiers.
     while (Constraint[0] == '=' || Constraint[0] == '+' || Constraint[0] == '&')