From: Simon Dardis Date: Thu, 20 Jul 2017 22:23:21 +0000 (+0000) Subject: [mips] Add support for -m(no-)local-sdata X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=53ae78a6e5ec1ff19a1eb10cf2557cf0d5624362;p=clang [mips] Add support for -m(no-)local-sdata Teach the driver to support -mlocal-sdata. The backend already matches GCC's default behaviour. Reviewers: atanasyan, slthakur Differential Revision: https://reviews.llvm.org/D35549 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@308683 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/clang/Driver/Options.td b/include/clang/Driver/Options.td index 0731ed62ef..d28dea7b63 100644 --- a/include/clang/Driver/Options.td +++ b/include/clang/Driver/Options.td @@ -2041,6 +2041,10 @@ def mgpopt : Flag<["-"], "mgpopt">, Group, def mno_gpopt : Flag<["-"], "mno-gpopt">, Group, HelpText<"Do not use GP relative accesses for symbols known to be in a small" " data section (MIPS)">; +def mlocal_sdata : Flag<["-"], "mlocal-sdata">, Group, + HelpText<"Extend the -G behaviour to object local data (MIPS)">; +def mno_local_sdata : Flag<["-"], "mno-local-sdata">, Group, + HelpText<"Do not extend the -G behaviour to object local data (MIPS)">; def mnan_EQ : Joined<["-"], "mnan=">, Group; def mabicalls : Flag<["-"], "mabicalls">, Group, HelpText<"Enable SVR4-style position-independent code (Mips only)">; diff --git a/lib/Driver/ToolChains/Clang.cpp b/lib/Driver/ToolChains/Clang.cpp index 6bb76d8035..8cfe61bf78 100644 --- a/lib/Driver/ToolChains/Clang.cpp +++ b/lib/Driver/ToolChains/Clang.cpp @@ -1480,6 +1480,19 @@ void Clang::AddMIPSTargetArgs(const ArgList &Args, if (NoABICalls && (!GPOpt || WantGPOpt)) { CmdArgs.push_back("-mllvm"); CmdArgs.push_back("-mgpopt"); + + Arg *LocalSData = Args.getLastArg(options::OPT_mlocal_sdata, + options::OPT_mno_local_sdata); + if (LocalSData) { + CmdArgs.push_back("-mllvm"); + if (LocalSData->getOption().matches(options::OPT_mlocal_sdata)) { + CmdArgs.push_back("-mlocal-sdata=1"); + } else { + CmdArgs.push_back("-mlocal-sdata=0"); + } + LocalSData->claim(); + } + } else if ((!ABICalls || (!NoABICalls && ABICalls)) && WantGPOpt) D.Diag(diag::warn_drv_unsupported_gpopt) << (ABICalls ? 0 : 1); diff --git a/test/Driver/mips-features.c b/test/Driver/mips-features.c index c637354911..4f6b05684c 100644 --- a/test/Driver/mips-features.c +++ b/test/Driver/mips-features.c @@ -35,6 +35,21 @@ // RUN: | FileCheck --check-prefix=CHECK-MGPOPTDEF %s // CHECK-MGPOPTDEF: "-mllvm" "-mgpopt" // +// -mgpopt -mno-abicalls -mlocal-sdata +// RUN: %clang -target mips-linux-gnu -### -c %s -mno-abicalls -mno-gpopt -mgpopt -mno-local-sdata -mlocal-sdata 2>&1 \ +// RUN: | FileCheck --check-prefix=CHECK-MLOCALSDATA %s +// CHECK-MLOCALSDATA: "-mllvm" "-mlocal-sdata=1" +// +// -mgpopt -mno-abicalls -mno-local-sdata +// RUN: %clang -target mips-linux-gnu -### -c %s -mno-abicalls -mno-gpopt -mgpopt -mlocal-sdata -mno-local-sdata 2>&1 \ +// RUN: | FileCheck --check-prefix=CHECK-MNOLOCALSDATA %s +// CHECK-MNOLOCALSDATA: "-mllvm" "-mlocal-sdata=0" +// +// -mgpopt -mno-abicalls +// RUN: %clang -target mips-linux-gnu -### -c %s -mno-abicalls -mgpopt 2>&1 \ +// RUN: | FileCheck --check-prefix=CHECK-MLOCALSDATADEF %s +// CHECK-MLOCALSDATADEF-NOT: "-mllvm" "-mlocal-sdata" +// // -mips16 // RUN: %clang -target mips-linux-gnu -### -c %s \ // RUN: -mno-mips16 -mips16 2>&1 \