From: Christoph M. Becker <cmbecker69@gmx.de>
Date: Mon, 7 Oct 2019 10:13:02 +0000 (+0200)
Subject: Delete temporary .post files of run-tests.php
X-Git-Tag: php-7.4.0RC4~51
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=53077217e2801f65dd3cb598f12aee2fa792742a;p=php

Delete temporary .post files of run-tests.php

Commit 5649267[1] changed run-tests.php to only delete .post files for
passing tests.  However, that code wouldn't be exercised at all, since
`run_test()` already returned, so we move the deletion upwards.

[1]
<http://git.php.net/?p=php-src.git;a=commit;h=5649267b257c78e46a934434c0bff894e0b5b694>
---

diff --git a/run-tests.php b/run-tests.php
index 89525f518b..909a8ea9b7 100755
--- a/run-tests.php
+++ b/run-tests.php
@@ -2624,6 +2624,7 @@ COMMAND $cmd
 			if (!$cfg['keep']['php']) {
 				@unlink($test_file);
 			}
+			@unlink($tmp_post);
 
 			if (!$leaked && !$failed_headers) {
 				if (isset($section_text['XFAIL'])) {
@@ -2653,6 +2654,7 @@ COMMAND $cmd
 			if (!$cfg['keep']['php']) {
 				@unlink($test_file);
 			}
+			@unlink($tmp_post);
 
 			if (!$leaked && !$failed_headers) {
 				if (isset($section_text['XFAIL'])) {
@@ -2692,10 +2694,6 @@ COMMAND $cmd
 		$restype[] = 'WARN';
 	}
 
-	if ($passed) {
-		@unlink($tmp_post);
-	}
-
 	if (!$passed) {
 		if (isset($section_text['XFAIL'])) {
 			$restype[] = 'XFAIL';