From: Jani Taskinen <jani@php.net>
Date: Wed, 9 Dec 2009 20:33:31 +0000 (+0000)
Subject: - Fixed bug #47179 (gzuncompress does not report expcted error)
X-Git-Tag: php-5.4.0alpha1~191^2~2256
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=52f573d629754c9a9cf842ab4b810f933d13e11f;p=php

- Fixed bug #47179 (gzuncompress does not report expcted error)
---

diff --git a/ext/zlib/tests/gzuncompress_error1.phpt b/ext/zlib/tests/gzuncompress_error1.phpt
index 8f9a42969f..99c419314d 100644
--- a/ext/zlib/tests/gzuncompress_error1.phpt
+++ b/ext/zlib/tests/gzuncompress_error1.phpt
@@ -1,7 +1,5 @@
 --TEST--
 Test gzuncompress() function : error conditions 
---XFAIL--
-Test will fail until bug #47179 resolved; no error when $length too small 
 --SKIPIF--
 <?php 
 if (!extension_loaded("zlib")) {
@@ -16,8 +14,6 @@ if (!extension_loaded("zlib")) {
  * Alias to functions: 
  */
 
-
-
 echo "*** Testing gzuncompress() : error conditions ***\n";
 
 // Zero arguments
@@ -34,14 +30,12 @@ var_dump( gzuncompress($data, $length, $extra_arg) );
 echo "\n-- Testing with Unicode string --\n";
 var_dump(gzuncompress($data, $length));
 
-
 echo "\n-- Testing with a buffer that is too small --\n";
 $short_len = strlen($data) - 1;
 $compressed = gzcompress(b"$data");
 
 var_dump(gzuncompress($compressed, $short_len));
 
-
 echo "\n-- Testing with incorrect arguments --\n";
 var_dump(gzuncompress(123));
 
@@ -77,7 +71,8 @@ Warning: gzuncompress() expects parameter 1 to be strictly a binary string, Unic
 NULL
 
 -- Testing with a buffer that is too small --
-Warning: gzuncompress(): buffer error in %s on line %d
+
+Warning: gzuncompress(): insufficient memory in %s on line %d
 bool(false)
 
 -- Testing with incorrect arguments --
@@ -90,4 +85,4 @@ NULL
 
 Warning: gzuncompress() expects parameter 2 to be long, Unicode string given in %s on line %d
 NULL
-===DONE===
\ No newline at end of file
+===DONE===
diff --git a/ext/zlib/zlib.c b/ext/zlib/zlib.c
index 1a77f022cf..b62e71bb3d 100644
--- a/ext/zlib/zlib.c
+++ b/ext/zlib/zlib.c
@@ -321,10 +321,10 @@ static inline int php_zlib_inflate_rounds(z_stream *Z, size_t max, char **buf, s
 	*buf = NULL;
 	*len = 0;
 
-	buffer.size = Z->avail_in;
+	buffer.size = (max && (max < Z->avail_in)) ? max : Z->avail_in;
 
 	do {
-		if ((max && (max < buffer.used)) || !(buffer.aptr = erealloc_recoverable(buffer.data, buffer.size))) {
+		if ((max && (max <= buffer.used)) || !(buffer.aptr = erealloc_recoverable(buffer.data, buffer.size))) {
 			status = Z_MEM_ERROR;
 		} else {
 			buffer.data = buffer.aptr;