From: Ted Kremenek <kremenek@apple.com>
Date: Tue, 19 Oct 2010 21:40:34 +0000 (+0000)
Subject: Revert most of r116862.  It isn't quite the right fix for a memory leak in Preprocessor.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=52a4ff6eae5d5e303c8b43022211e6d3ed429254;p=clang

Revert most of r116862.  It isn't quite the right fix for a memory leak in Preprocessor.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@116864 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Lex/PPDirectives.cpp b/lib/Lex/PPDirectives.cpp
index 9138af064f..b958d9e489 100644
--- a/lib/Lex/PPDirectives.cpp
+++ b/lib/Lex/PPDirectives.cpp
@@ -58,11 +58,7 @@ MacroInfo *Preprocessor::CloneMacroInfo(const MacroInfo &MacroToClone) {
 ///  be reused for allocating new MacroInfo objects.
 void Preprocessor::ReleaseMacroInfo(MacroInfo *MI) {
   MICache.push_back(MI);
-  // We need to call 'Destroy' as opposed to 'FreeArgumentList' because
-  // the MICache object will get reused with a placement new.  This does
-  // not cause the underlying SmallVector to get it's memory released, so
-  // we need to call Destroy() here.
-  MI->Destroy();
+  MI->FreeArgumentList();
 }