From: Ivan Maidanski <ivmai@mail.ru>
Date: Mon, 12 Nov 2018 07:52:01 +0000 (+0300)
Subject: Fix 'too wide non-owner permissions are set for resource' code defect
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5260eb0d79231a2a0800a38a037d361d3502ab48;p=gc

Fix 'too wide non-owner permissions are set for resource' code defect

* misc.c [(UNIX_LIKE && !GC_ANDROID_LOG || CYGWIN32 || SYMBIAN)
&& !SMALL_CONFIG] (GC_init): Pass 0644 permissions mode instead of 0666
to open (create) a log file.
* os_dep.c [MMAP_SUPPORTED && !USE_MMAP_ANON && SYMBIAN]
(GC_unix_mmap_get_mem): Pass 0644 mode instead of 0666 to open "zero"
file.
---

diff --git a/misc.c b/misc.c
index d45b9b57..2f001d01 100644
--- a/misc.c
+++ b/misc.c
@@ -1031,7 +1031,7 @@ GC_API void GC_CALL GC_init(void)
             if (0 != file_name)
 #         endif
           {
-            int log_d = open(file_name, O_CREAT|O_WRONLY|O_APPEND, 0666);
+            int log_d = open(file_name, O_CREAT | O_WRONLY | O_APPEND, 0644);
             if (log_d < 0) {
               GC_err_printf("Failed to open %s as log file\n", file_name);
             } else {
diff --git a/os_dep.c b/os_dep.c
index ea08ebad..dd616003 100644
--- a/os_dep.c
+++ b/os_dep.c
@@ -2163,7 +2163,7 @@ void GC_register_data_segments(void)
 #       ifdef SYMBIAN
           char *path = GC_get_private_path_and_zero_file();
           if (path != NULL) {
-            zero_fd = open(path, O_RDWR | O_CREAT, 0666);
+            zero_fd = open(path, O_RDWR | O_CREAT, 0644);
             free(path);
           }
 #       else