From: Mike Stump <mrs@apple.com>
Date: Tue, 28 Jul 2009 00:07:08 +0000 (+0000)
Subject: Make sure to move the comment with the code.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=523a8fddefee7836d6317f6dc265acb4ee84a0d4;p=clang

Make sure to move the comment with the code.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@77279 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/clang/Basic/Builtins.def b/include/clang/Basic/Builtins.def
index 9c5edf38bc..b2d31f2215 100644
--- a/include/clang/Basic/Builtins.def
+++ b/include/clang/Basic/Builtins.def
@@ -387,9 +387,6 @@ LIBBUILTIN(rindex, "c*cC*i",      "f",     "strings.h")
 // but we need new type letters for that.
 LIBBUILTIN(objc_msgSend, "v*.",   "f",     "objc/message.h")
 
-// FIXME: asprintf and vasprintf aren't C99 functions. Should they be
-// target-specific builtins, perhaps? 
-
 // Builtin math library functions
 LIBBUILTIN(pow, "ddd", "fe", "math.h")
 LIBBUILTIN(powl, "LdLdLd", "fe", "math.h")
diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp
index 27c109f9f0..7ab7356aa0 100644
--- a/lib/Sema/SemaDecl.cpp
+++ b/lib/Sema/SemaDecl.cpp
@@ -3695,6 +3695,7 @@ void Sema::AddKnownFunctionAttributes(FunctionDecl *FD) {
     return;
 
   if (Name->isStr("NSLog") || Name->isStr("NSLogv")) {
+    // FIXME: NSLog and NSLogv should be target specific
     if (const FormatAttr *Format = FD->getAttr<FormatAttr>()) {
       // FIXME: We known better than our headers.
       const_cast<FormatAttr *>(Format)->setType("printf");
@@ -3702,6 +3703,8 @@ void Sema::AddKnownFunctionAttributes(FunctionDecl *FD) {
       FD->addAttr(::new (Context) FormatAttr("printf", 1,
                                              Name->isStr("NSLogv") ? 0 : 2));
   } else if (Name->isStr("asprintf") || Name->isStr("vasprintf")) {
+    // FIXME: asprintf and vasprintf aren't C99 functions. Should they be
+    // target-specific builtins, perhaps? 
     if (!FD->getAttr<FormatAttr>())
       FD->addAttr(::new (Context) FormatAttr("printf", 2,
                                              Name->isStr("vasprintf") ? 0 : 3));