From: Eric Liu Date: Thu, 24 Mar 2016 13:22:37 +0000 (+0000) Subject: Revert "Added support for different VFSs in format::getStyle." X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5229f7e0fc4f6c8ca25cb8ee40affde4a6d548a3;p=clang Revert "Added support for different VFSs in format::getStyle." This reverts commit r264253. It is breaking the buildbot http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/2203 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@264276 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Format/Format.cpp b/lib/Format/Format.cpp index 6d03b62920..31dc259d4c 100644 --- a/lib/Format/Format.cpp +++ b/lib/Format/Format.cpp @@ -2099,10 +2099,7 @@ static FormatStyle::LanguageKind getLanguageByFileName(StringRef FileName) { } FormatStyle getStyle(StringRef StyleName, StringRef FileName, - StringRef FallbackStyle, vfs::FileSystem *FS) { - if (!FS) { - FS = vfs::getRealFileSystem().get(); - } + StringRef FallbackStyle) { FormatStyle Style = getLLVMStyle(); Style.Language = getLanguageByFileName(FileName); if (!getPredefinedStyle(FallbackStyle, Style.Language, &Style)) { @@ -2133,35 +2130,28 @@ FormatStyle getStyle(StringRef StyleName, StringRef FileName, llvm::sys::fs::make_absolute(Path); for (StringRef Directory = Path; !Directory.empty(); Directory = llvm::sys::path::parent_path(Directory)) { - - auto Status = FS->status(Directory); - if (!Status || - Status->getType() != llvm::sys::fs::file_type::directory_file) { + if (!llvm::sys::fs::is_directory(Directory)) continue; - } - SmallString<128> ConfigFile(Directory); llvm::sys::path::append(ConfigFile, ".clang-format"); DEBUG(llvm::dbgs() << "Trying " << ConfigFile << "...\n"); + bool IsFile = false; // Ignore errors from is_regular_file: we only need to know if we can read // the file or not. - Status = FS->status(ConfigFile.str()); - bool IsFile = - Status && (Status->getType() == llvm::sys::fs::file_type::regular_file); + llvm::sys::fs::is_regular_file(Twine(ConfigFile), IsFile); + if (!IsFile) { // Try _clang-format too, since dotfiles are not commonly used on Windows. ConfigFile = Directory; llvm::sys::path::append(ConfigFile, "_clang-format"); DEBUG(llvm::dbgs() << "Trying " << ConfigFile << "...\n"); - Status = FS->status(ConfigFile.str()); - IsFile = Status && - (Status->getType() == llvm::sys::fs::file_type::regular_file); + llvm::sys::fs::is_regular_file(Twine(ConfigFile), IsFile); } if (IsFile) { llvm::ErrorOr> Text = - FS->getBufferForFile(ConfigFile.str()); + llvm::MemoryBuffer::getFile(ConfigFile.c_str()); if (std::error_code EC = Text.getError()) { llvm::errs() << EC.message() << "\n"; break;