From: Serhiy Storchaka <storchaka@gmail.com>
Date: Sat, 4 Oct 2014 10:39:34 +0000 (+0300)
Subject: Issue #22219: The zipfile module CLI now adds entries for directories
X-Git-Tag: v3.5.0a1~768^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=518e71b18a008947b17369de5c06d9543db7dfc5;p=python

Issue #22219: The zipfile module CLI now adds entries for directories
(including empty directories) in ZIP file.
---

diff --git a/Lib/zipfile.py b/Lib/zipfile.py
index 7e07f11d79..bda6134357 100644
--- a/Lib/zipfile.py
+++ b/Lib/zipfile.py
@@ -1790,14 +1790,21 @@ def main(args = None):
             if os.path.isfile(path):
                 zf.write(path, zippath, ZIP_DEFLATED)
             elif os.path.isdir(path):
+                if zippath:
+                    zf.write(path, zippath)
                 for nm in os.listdir(path):
                     addToZip(zf,
                              os.path.join(path, nm), os.path.join(zippath, nm))
             # else: ignore
 
         with ZipFile(args[1], 'w') as zf:
-            for src in args[2:]:
-                addToZip(zf, src, os.path.basename(src))
+            for path in args[2:]:
+                zippath = os.path.basename(path)
+                if not zippath:
+                    zippath = os.path.basename(os.path.dirname(path))
+                if zippath in ('', os.curdir, os.pardir):
+                    zippath = ''
+                addToZip(zf, path, zippath)
 
 if __name__ == "__main__":
     main()
diff --git a/Misc/NEWS b/Misc/NEWS
index 5934d5bc32..671cc50270 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -19,6 +19,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #22219: The zipfile module CLI now adds entries for directories
+  (including empty directories) in ZIP file.
+
 - Issue #22449: In the ssl.SSLContext.load_default_certs, consult the
   enviromental variables SSL_CERT_DIR and SSL_CERT_FILE on Windows.