From: Guido van Rossum <guido@python.org>
Date: Fri, 25 Apr 2003 15:01:05 +0000 (+0000)
Subject: Fix the tests on Windows, by writing the test data file in binary
X-Git-Tag: v2.3c1~985
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=51735b0569e4bff3f9a2988f0273cd5f1e3ec471;p=python

Fix the tests on Windows, by writing the test data file in binary
mode.

XXX I'm not convinced that this is the right solution -- arguably,
on Windows, the _fileobject class should honor the mode argument
and do newline translation.  But it's never done that so I think
there's no urgent need to fix this today.
---

diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py
index 67252891d6..7d557a1e08 100644
--- a/Lib/test/test_urllib.py
+++ b/Lib/test/test_urllib.py
@@ -24,7 +24,7 @@ class urlopen_FileTests(unittest.TestCase):
     def setUp(self):
         """Setup of a temp file to use for testing"""
         self.text = "test_urllib: %s\n" % self.__class__.__name__
-        FILE = file(test_support.TESTFN, 'w')
+        FILE = file(test_support.TESTFN, 'wb')
         try:
             FILE.write(self.text)
         finally: