From: Éric Araujo Date: Thu, 2 Dec 2010 22:16:19 +0000 (+0000) Subject: Fix wrong test code in test_csv (#10602) X-Git-Tag: v3.2b1~121 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5137d648cd5b586d1f7063ce9e625cb6c2996704;p=python Fix wrong test code in test_csv (#10602) --- diff --git a/Lib/test/test_csv.py b/Lib/test/test_csv.py index c3da185e10..8ca1e62c4a 100644 --- a/Lib/test/test_csv.py +++ b/Lib/test/test_csv.py @@ -313,22 +313,17 @@ class TestDialectRegistry(unittest.TestCase): expected_dialects = csv.list_dialects() + [name] expected_dialects.sort() csv.register_dialect(name, myexceltsv) - try: - self.assertTrue(csv.get_dialect(name).delimiter, '\t') - got_dialects = csv.list_dialects() - got_dialects.sort() - self.assertEqual(expected_dialects, got_dialects) - finally: - csv.unregister_dialect(name) + self.addCleanup(csv.unregister_dialect, name) + self.assertEqual(csv.get_dialect(name).delimiter, '\t') + got_dialects = sorted(csv.list_dialects()) + self.assertEqual(expected_dialects, got_dialects) def test_register_kwargs(self): name = 'fedcba' csv.register_dialect(name, delimiter=';') - try: - self.assertTrue(csv.get_dialect(name).delimiter, '\t') - self.assertTrue(list(csv.reader('X;Y;Z', name)), ['X', 'Y', 'Z']) - finally: - csv.unregister_dialect(name) + self.addCleanup(csv.unregister_dialect, name) + self.assertEqual(csv.get_dialect(name).delimiter, ';') + self.assertEqual([['X', 'Y', 'Z']], list(csv.reader(['X;Y;Z'], name))) def test_incomplete_dialect(self): class myexceltsv(csv.Dialect):