From: Ivan Maidanski <ivmai@mail.ru>
Date: Sat, 29 Oct 2016 14:40:01 +0000 (+0300)
Subject: Revert "Eliminate 'deref-of-null' static analyzer warning in register_finalizer"
X-Git-Tag: v8.0.0~1052
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=51260a32883c2824adcd44f69185e0cb2db39153;p=gc

Revert "Eliminate 'deref-of-null' static analyzer warning in register_finalizer"

This reverts commit 7547c377153ddd859bef6a2dd14c42e9f12aa0be.

Because it requires -D GC_ASSERTIONS.
---

diff --git a/finalize.c b/finalize.c
index 9f03f81a..3de2a9c8 100644
--- a/finalize.c
+++ b/finalize.c
@@ -699,8 +699,7 @@ STATIC void GC_register_finalizer_inner(void * obj,
         curr_fo = fo_next(curr_fo);
       }
       if (EXPECT(new_fo != 0, FALSE)) {
-        /* new_fo is returned by GC_oom_fn().   */
-        GC_ASSERT(fn != 0 && hhdr != NULL);
+        /* new_fo is returned by GC_oom_fn(), so fn != 0 and hhdr != 0. */
         break;
       }
       if (fn == 0) {