From: Daniel Berlin Date: Mon, 20 Jun 2016 20:21:33 +0000 (+0000) Subject: Rename to be consistent with other type names. NFC X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=50d58070c01f2454790594459c2ae6fa9ecf0e83;p=llvm Rename to be consistent with other type names. NFC git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@273194 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/llvm/Transforms/Utils/MemorySSA.h b/include/llvm/Transforms/Utils/MemorySSA.h index e9638e83ae6..487fcb972d4 100644 --- a/include/llvm/Transforms/Utils/MemorySSA.h +++ b/include/llvm/Transforms/Utils/MemorySSA.h @@ -526,12 +526,12 @@ public: return LiveOnEntryDef.get(); } - using AccessListType = iplist; + using AccessList = iplist; /// \brief Return the list of MemoryAccess's for a given basic block. /// /// This list is not modifiable by the user. - const AccessListType *getBlockAccesses(const BasicBlock *BB) const { + const AccessList *getBlockAccesses(const BasicBlock *BB) const { auto It = PerBlockAccesses.find(BB); return It == PerBlockAccesses.end() ? nullptr : It->second.get(); } @@ -563,8 +563,7 @@ protected: private: void verifyUseInDefs(MemoryAccess *, MemoryAccess *) const; - using AccessMap = - DenseMap>; + using AccessMap = DenseMap>; void determineInsertionPoint(const SmallPtrSetImpl &DefiningBlocks); @@ -578,7 +577,7 @@ private: MemoryAccess *renameBlock(BasicBlock *, MemoryAccess *); void renamePass(DomTreeNode *, MemoryAccess *IncomingVal, SmallPtrSet &Visited); - AccessListType *getOrCreateAccessList(BasicBlock *); + AccessList *getOrCreateAccessList(BasicBlock *); AliasAnalysis *AA; DominatorTree *DT; Function &F; diff --git a/lib/Transforms/Utils/MemorySSA.cpp b/lib/Transforms/Utils/MemorySSA.cpp index 26c4931c78e..f40d658fc54 100644 --- a/lib/Transforms/Utils/MemorySSA.cpp +++ b/lib/Transforms/Utils/MemorySSA.cpp @@ -105,7 +105,7 @@ MemoryAccess *MemorySSA::renameBlock(BasicBlock *BB, auto It = PerBlockAccesses.find(BB); // Skip most processing if the list is empty. if (It != PerBlockAccesses.end()) { - AccessListType *Accesses = It->second.get(); + AccessList *Accesses = It->second.get(); for (MemoryAccess &L : *Accesses) { switch (L.getValueID()) { case Value::MemoryUseVal: @@ -132,7 +132,7 @@ MemoryAccess *MemorySSA::renameBlock(BasicBlock *BB, // Rename the phi nodes in our successor block if (It == PerBlockAccesses.end() || !isa(It->second->front())) continue; - AccessListType *Accesses = It->second.get(); + AccessList *Accesses = It->second.get(); auto *Phi = cast(&Accesses->front()); assert(std::find(succ_begin(BB), succ_end(BB), S) != succ_end(BB) && "Must be at least one edge from Succ to BB!"); @@ -226,11 +226,11 @@ MemorySSA::~MemorySSA() { MA.dropAllReferences(); } -MemorySSA::AccessListType *MemorySSA::getOrCreateAccessList(BasicBlock *BB) { +MemorySSA::AccessList *MemorySSA::getOrCreateAccessList(BasicBlock *BB) { auto Res = PerBlockAccesses.insert(std::make_pair(BB, nullptr)); if (Res.second) - Res.first->second = make_unique(); + Res.first->second = make_unique(); return Res.first->second.get(); } @@ -259,7 +259,7 @@ MemorySSAWalker *MemorySSA::getWalker() { // the accesses. for (BasicBlock &B : F) { bool InsertIntoDef = false; - AccessListType *Accesses = nullptr; + AccessList *Accesses = nullptr; for (Instruction &I : B) { MemoryUseOrDef *MUD = createNewAccess(&I); if (!MUD) @@ -319,7 +319,7 @@ MemorySSAWalker *MemorySSA::getWalker() { // Now place MemoryPhi nodes. for (auto &BB : IDFBlocks) { // Insert phi node - AccessListType *Accesses = getOrCreateAccessList(BB); + AccessList *Accesses = getOrCreateAccessList(BB); MemoryPhi *Phi = new MemoryPhi(F.getContext(), BB, NextID++); ValueToMemoryAccess.insert(std::make_pair(BB, Phi)); // Phi's always are placed at the front of the block. @@ -340,7 +340,7 @@ MemorySSAWalker *MemorySSA::getWalker() { auto AI = PerBlockAccesses.find(BB); if (AI == PerBlockAccesses.end()) continue; - AccessListType *Accesses = AI->second.get(); + AccessList *Accesses = AI->second.get(); for (auto &MA : *Accesses) { if (auto *MU = dyn_cast(&MA)) { Instruction *Inst = MU->getMemoryInst(); @@ -472,7 +472,7 @@ void MemorySSA::removeFromLookups(MemoryAccess *MA) { ValueToMemoryAccess.erase(MemoryInst); auto AccessIt = PerBlockAccesses.find(MA->getBlock()); - std::unique_ptr &Accesses = AccessIt->second; + std::unique_ptr &Accesses = AccessIt->second; Accesses->erase(MA); if (Accesses->empty()) PerBlockAccesses.erase(AccessIt); @@ -552,7 +552,8 @@ void MemorySSA::verifyDomination(Function &F) const { continue; for (User *U : MD->users()) { - BasicBlock *UseBlock; (void)UseBlock; + BasicBlock *UseBlock; + (void)UseBlock; // Things are allowed to flow to phi nodes over their predecessor edge. if (auto *P = dyn_cast(U)) { for (const auto &Arg : P->operands()) { @@ -640,8 +641,8 @@ bool MemorySSA::locallyDominates(const MemoryAccess *Dominator, return true; // Get the access list for the block - const AccessListType *AccessList = getBlockAccesses(Dominator->getBlock()); - AccessListType::const_reverse_iterator It(Dominator->getIterator()); + const AccessList *AccessList = getBlockAccesses(Dominator->getBlock()); + AccessList::const_reverse_iterator It(Dominator->getIterator()); // If we hit the beginning of the access list before we hit dominatee, we must // dominate it