From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Sun, 11 Jul 2021 02:42:24 +0000 (-0700)
Subject: deal exclusively in size_t in Java bindings support code
X-Git-Tag: 2.49.0~62^2~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=50c99544e09ab13a67f2b4b305896f822ca96a43;p=graphviz

deal exclusively in size_t in Java bindings support code

In this code, committed in c7374588519a7ac557c14b38c147623dedf43fdb in 2014, it
is not clear to me why int was used. The correct type for these kind of
operations is size_t. The size_t type has been available since at least 1995, if
not earlier depending on your toolchain. Squashes 3
-Wsign-conversion/-Wconversion warnings.
---

diff --git a/tclpkg/gv/gv_java_init.c b/tclpkg/gv/gv_java_init.c
index 54b4f2e46..66193d11a 100644
--- a/tclpkg/gv/gv_java_init.c
+++ b/tclpkg/gv/gv_java_init.c
@@ -17,15 +17,14 @@
 
 typedef struct {
     char* data;
-    int sz;       /* buffer size */
-    int len;      /* length of array */
+    size_t sz;       /* buffer size */
+    size_t len;      /* length of array */
 } BA;
 
 static size_t gv_string_writer(GVJ_t *job, const char *s, size_t len)
 {
     BA* bap = (BA*)(job->output_file);
-/* fprintf (stderr, "newlen %ld data %p sz %d len %d\n", len, bap->data,bap->sz, bap->len); */
-    int newlen = bap->len + len;
+    size_t newlen = bap->len + len;
     if (newlen > bap->sz) {
 	bap->sz *= 2;
 	if (newlen > bap->sz)