From: Dmitry Venikov <quolyk@gmail.com>
Date: Sun, 3 Feb 2019 03:48:30 +0000 (+0000)
Subject: [InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=505cfd572ae5be750c3a64e4ec50513578bd6358;p=llvm

[InstSimplify] Missed optimization in math expression: log10(pow(10.0,x)) == x, log2(pow(2.0,x)) == x

Summary: This patch enables folding following instructions under -ffast-math flag: log10(pow(10.0,x)) -> x, log2(pow(2.0,x)) -> x

Reviewers: hfinkel, spatel, efriedma, craig.topper, zvi, majnemer, lebedev.ri

Reviewed By: spatel, lebedev.ri

Subscribers: lebedev.ri, llvm-commits

Differential Revision: https://reviews.llvm.org/D41940

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@352981 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/InstructionSimplify.cpp b/lib/Analysis/InstructionSimplify.cpp
index ed3ba7778a0..c83d62f1542 100644
--- a/lib/Analysis/InstructionSimplify.cpp
+++ b/lib/Analysis/InstructionSimplify.cpp
@@ -4940,7 +4940,15 @@ static Value *simplifyUnaryIntrinsic(Function *F, Value *Op0,
   case Intrinsic::log2:
     // log2(exp2(x)) -> x
     if (Q.CxtI->hasAllowReassoc() &&
-        match(Op0, m_Intrinsic<Intrinsic::exp2>(m_Value(X)))) return X;
+        (match(Op0, m_Intrinsic<Intrinsic::exp2>(m_Value(X))) ||
+         match(Op0, m_Intrinsic<Intrinsic::pow>(m_SpecificFP(2.0),
+                                                m_Value(X))))) return X;
+    break;
+  case Intrinsic::log10:
+    // log10(pow(10.0, x)) -> x
+    if (Q.CxtI->hasAllowReassoc() &&
+        match(Op0, m_Intrinsic<Intrinsic::pow>(m_SpecificFP(10.0),
+                                               m_Value(X)))) return X;
     break;
   default:
     break;
diff --git a/test/Transforms/InstSimplify/log10-pow10-intrinsic.ll b/test/Transforms/InstSimplify/log10-pow10-intrinsic.ll
index f0ffbf49b9a..a5b7afde1a8 100644
--- a/test/Transforms/InstSimplify/log10-pow10-intrinsic.ll
+++ b/test/Transforms/InstSimplify/log10-pow10-intrinsic.ll
@@ -28,9 +28,7 @@ define double @log10_strict_pow10_reassoc(double %x) {
 
 define double @log10_reassoc_pow10_strict(double %x) {
 ; CHECK-LABEL: @log10_reassoc_pow10_strict(
-; CHECK-NEXT:    [[TMP1:%.*]] = call double @llvm.pow.f64(double 1.000000e+01, double [[X:%.*]])
-; CHECK-NEXT:    [[TMP2:%.*]] = call reassoc double @llvm.log10.f64(double [[TMP1]])
-; CHECK-NEXT:    ret double [[TMP2]]
+; CHECK-NEXT:    ret double [[X:%.*]]
 ;
   %tmp = call double @llvm.pow.f64(double 1.000000e+01, double %x)
   %tmp1 = call reassoc double @llvm.log10.f64(double %tmp)
@@ -39,9 +37,7 @@ define double @log10_reassoc_pow10_strict(double %x) {
 
 define double @log10_pow10_reassoc(double %x) {
 ; CHECK-LABEL: @log10_pow10_reassoc(
-; CHECK-NEXT:    [[TMP1:%.*]] = call reassoc double @llvm.pow.f64(double 1.000000e+01, double [[X:%.*]])
-; CHECK-NEXT:    [[TMP2:%.*]] = call reassoc double @llvm.log10.f64(double [[TMP1]])
-; CHECK-NEXT:    ret double [[TMP2]]
+; CHECK-NEXT:    ret double [[X:%.*]]
 ;
   %tmp = call reassoc double @llvm.pow.f64(double 1.000000e+01, double %x)
   %tmp1 = call reassoc double @llvm.log10.f64(double %tmp)
diff --git a/test/Transforms/InstSimplify/log2-pow2-intrinsic.ll b/test/Transforms/InstSimplify/log2-pow2-intrinsic.ll
index 519db518a4a..8d8ef80db72 100644
--- a/test/Transforms/InstSimplify/log2-pow2-intrinsic.ll
+++ b/test/Transforms/InstSimplify/log2-pow2-intrinsic.ll
@@ -28,9 +28,7 @@ define double @log2_strict_pow2_reassoc(double %x) {
 
 define double @log2_reassoc_pow2_strict(double %x) {
 ; CHECK-LABEL: @log2_reassoc_pow2_strict(
-; CHECK-NEXT:    [[TMP:%.*]] = call double @llvm.pow.f64(double 2.000000e+00, double [[X:%.*]])
-; CHECK-NEXT:    [[TMP1:%.*]] = call reassoc double @llvm.log2.f64(double [[TMP]])
-; CHECK-NEXT:    ret double [[TMP1]]
+; CHECK-NEXT:    ret double [[X:%.*]]
 ;
   %tmp = call double @llvm.pow.f64(double 2.000000e+00, double %x)
   %tmp1 = call reassoc double @llvm.log2.f64(double %tmp)
@@ -39,9 +37,7 @@ define double @log2_reassoc_pow2_strict(double %x) {
 
 define double @log2_pow2_reassoc(double %x) {
 ; CHECK-LABEL: @log2_pow2_reassoc(
-; CHECK-NEXT:    [[TMP:%.*]] = call reassoc double @llvm.pow.f64(double 2.000000e+00, double [[X:%.*]])
-; CHECK-NEXT:    [[TMP1:%.*]] = call reassoc double @llvm.log2.f64(double [[TMP]])
-; CHECK-NEXT:    ret double [[TMP1]]
+; CHECK-NEXT:    ret double [[X:%.*]]
 ;
   %tmp = call reassoc double @llvm.pow.f64(double 2.000000e+00, double %x)
   %tmp1 = call reassoc double @llvm.log2.f64(double %tmp)