From: Rhodri James <rhodri@kynesim.co.uk>
Date: Mon, 12 Jun 2017 14:52:21 +0000 (+0100)
Subject: Test UTF-16 big-endian BOM vs explicit Latin-1 encoding
X-Git-Tag: R_2_2_3~22^2~73
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4f9f6651b718da6207445212509e20b3e10a69c3;p=libexpat

Test UTF-16 big-endian BOM vs explicit Latin-1 encoding
---

diff --git a/expat/tests/runtests.c b/expat/tests/runtests.c
index 314ff398..08ba2848 100644
--- a/expat/tests/runtests.c
+++ b/expat/tests/runtests.c
@@ -5634,6 +5634,42 @@ START_TEST(test_ext_entity_latin1_utf16le_bom)
 }
 END_TEST
 
+START_TEST(test_ext_entity_latin1_utf16be_bom)
+{
+    const char *text =
+        "<!DOCTYPE doc [\n"
+        "  <!ENTITY en SYSTEM 'http://example.org/dummy.ent'>\n"
+        "]>\n"
+        "<doc>&en;</doc>";
+    ExtTest2 test_data = {
+        /* If UTF-16, 0xfeff is the BOM and 0x204c is black left bullet */
+        /* If Latin-1, 0xff = Y-diaeresis, 0xfe = lowercase thorn,
+         *   0x4c = L and 0x20 is a space
+         */
+        "\xfe\xff\x20\x4c",
+        4,
+        "iso-8859-1",
+        NULL,
+        EE_PARSE_NONE
+    };
+    /* In UTF-8, y-diaeresis is 0xc3 0xbf, lowercase thorn is 0xc3 0xbe */
+    const XML_Char *expected = "\xc3\xbe\xc3\xbf L";
+    CharData storage;
+
+
+    CharData_Init(&storage);
+    test_data.storage = &storage;
+    XML_SetExternalEntityRefHandler(parser, external_entity_loader2);
+    XML_SetUserData(parser, &test_data);
+    XML_SetCharacterDataHandler(parser, ext2_accumulate_characters);
+    if (_XML_Parse_SINGLE_BYTES(parser, text, strlen(text),
+                                XML_TRUE) == XML_STATUS_ERROR)
+        xml_failure(parser);
+    CharData_CheckXMLChars(&storage, expected);
+}
+END_TEST
+
+
 /* Parsing the full buffer rather than a byte at a time makes a
  * difference to the encoding scanning code, so repeat the above test
  * without breaking it down by byte.
@@ -10970,6 +11006,7 @@ make_suite(void)
     tcase_add_test(tc_basic, test_unknown_encoding_invalid_surrogate);
     tcase_add_test(tc_basic, test_unknown_encoding_invalid_high);
     tcase_add_test(tc_basic, test_ext_entity_latin1_utf16le_bom);
+    tcase_add_test(tc_basic, test_ext_entity_latin1_utf16be_bom);
     tcase_add_test(tc_basic, test_ext_entity_latin1_utf16le_bom2);
 
     suite_add_tcase(s, tc_namespace);