From: Guido van Rossum <guido@python.org>
Date: Mon, 29 Sep 1997 23:31:11 +0000 (+0000)
Subject: Don't intern the key string for getitem and delitem.
X-Git-Tag: v1.5a4~121
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4f3bf1e383c0a5d10c8b581d0ca6d0140e3abce6;p=python

Don't intern the key string for getitem and delitem.
---

diff --git a/Objects/dictobject.c b/Objects/dictobject.c
index 66cec0c71c..3362655b4c 100644
--- a/Objects/dictobject.c
+++ b/Objects/dictobject.c
@@ -1011,7 +1011,6 @@ PyDict_GetItemString(v, key)
 	kv = PyString_FromString(key);
 	if (kv == NULL)
 		return NULL;
-	PyString_InternInPlace(&kv);
 	rv = PyDict_GetItem(v, kv);
 	Py_DECREF(kv);
 	return rv;
@@ -1028,7 +1027,7 @@ PyDict_SetItemString(v, key, item)
 	kv = PyString_FromString(key);
 	if (kv == NULL)
 		return -1;
-	PyString_InternInPlace(&kv);
+	PyString_InternInPlace(&kv); /* XXX Should we really? */
 	err = PyDict_SetItem(v, kv, item);
 	Py_DECREF(kv);
 	return err;
@@ -1044,7 +1043,6 @@ PyDict_DelItemString(v, key)
 	kv = PyString_FromString(key);
 	if (kv == NULL)
 		return -1;
-	PyString_InternInPlace(&kv);
 	err = PyDict_DelItem(v, kv);
 	Py_DECREF(kv);
 	return err;