From: Bram Moolenaar <Bram@vim.org>
Date: Mon, 19 Apr 2021 19:06:31 +0000 (+0200)
Subject: patch 8.2.2786: Vim9: memory leak when using :s with expression
X-Git-Tag: v8.2.2786
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4f2df37a0d297a0f40ff15f8ce31285c7b529bcd;p=vim

patch 8.2.2786: Vim9: memory leak when using :s with expression

Problem:    Vim9: memory leak when using :s with expression.
Solution:   Clean up the instruction list.
---

diff --git a/src/version.c b/src/version.c
index 22a2751bd..834196d83 100644
--- a/src/version.c
+++ b/src/version.c
@@ -750,6 +750,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    2786,
 /**/
     2785,
 /**/
diff --git a/src/vim9compile.c b/src/vim9compile.c
index 027f79d95..0695879e3 100644
--- a/src/vim9compile.c
+++ b/src/vim9compile.c
@@ -9416,8 +9416,15 @@ delete_instr(isn_T *isn)
 	    break;
 
 	case ISN_SUBSTITUTE:
-	    vim_free(isn->isn_arg.subs.subs_cmd);
-	    vim_free(isn->isn_arg.subs.subs_instr);
+	    {
+		int	idx;
+		isn_T	*list = isn->isn_arg.subs.subs_instr;
+
+		vim_free(isn->isn_arg.subs.subs_cmd);
+		for (idx = 0; list[idx].isn_type != ISN_FINISH; ++idx)
+		    delete_instr(list + idx);
+		vim_free(list);
+	    }
 	    break;
 
 	case ISN_LOADS: