From: Raymond Hettinger <python@rcn.com>
Date: Sat, 30 Aug 2003 00:10:06 +0000 (+0000)
Subject: For safety, replace a tuple entry before decreffing it.
X-Git-Tag: v2.4a1~1688
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4f01f89b8c35235acfc93bcc4f6fe1b2645c0295;p=python

For safety, replace a tuple entry before decreffing it.
---

diff --git a/Modules/itertoolsmodule.c b/Modules/itertoolsmodule.c
index 4dca054d24..68e176f23d 100644
--- a/Modules/itertoolsmodule.c
+++ b/Modules/itertoolsmodule.c
@@ -1591,6 +1591,7 @@ izip_next(izipobject *lz)
 	PyObject *result = lz->result;
 	PyObject *it;
 	PyObject *item;
+	PyObject *olditem;
 
 	if (tuplesize == 0)
 		return NULL;
@@ -1604,8 +1605,9 @@ izip_next(izipobject *lz)
 				Py_DECREF(result);
 				return NULL;
 			}
-			Py_DECREF(PyTuple_GET_ITEM(result, i));
+			olditem = PyTuple_GET_ITEM(result, i);
 			PyTuple_SET_ITEM(result, i, item);
+			Py_DECREF(olditem);
 		}
 	} else {
 		result = PyTuple_New(tuplesize);