From: Angus Gratton <angus@espressif.com>
Date: Thu, 1 Feb 2018 03:46:40 +0000 (+0800)
Subject: idf_monitor: Fix remaining case of Windows "console write fails" bug
X-Git-Tag: v3.1-beta1~420^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4eab275a51a8baede23b9a38c81214c2a930a644;p=esp-idf

idf_monitor: Fix remaining case of Windows "console write fails" bug

Closes https://github.com/espressif/esp-idf/pull/1567
---

diff --git a/tools/idf_monitor.py b/tools/idf_monitor.py
index 2bf2a9d238..f0dcd6f7c6 100755
--- a/tools/idf_monitor.py
+++ b/tools/idf_monitor.py
@@ -579,6 +579,17 @@ if os.name == 'nt':
             self.handle = GetStdHandle(STD_ERROR_HANDLE if self.output == sys.stderr else STD_OUTPUT_HANDLE)
             self.matched = b''
 
+        def _output_write(self, data):
+            # Windows 10 bug since the Fall Creators Update, sometimes writing to console randomly fails
+            # (but usually succeeds afterwards, it seems.)
+            # Ref https://github.com/espressif/esp-idf/issues/1136
+            for tries in range(3):
+                try:
+                    self.output.write(data)
+                    return
+                except IOError:
+                    pass
+
         def write(self, data):
             for b in data:
                 l = len(self.matched)
@@ -597,18 +608,10 @@ if os.name == 'nt':
                                 color |= FOREGROUND_INTENSITY
                             SetConsoleTextAttribute(self.handle, color)
                         else:
-                            self.output.write(self.matched) # not an ANSI color code, display verbatim
+                            self._output_write(self.matched) # not an ANSI color code, display verbatim
                         self.matched = b''
                 else:
-                    try:
-                        self.output.write(b)
-                    except IOError:
-                        # Windows 10 bug since the Fall Creators Update, sometimes writing to console randomly fails
-                        # (but usually succeeds the second time, it seems.) Ref https://github.com/espressif/esp-idf/issues/1136
-                        try:
-                            self.output.write(b)
-                        except IOError:
-                            pass
+                    self._output_write(b)
                     self.matched = b''
 
         def flush(self):