From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Tue, 3 Feb 2015 07:43:44 +0000 (+0200)
Subject: Remove dead code.
X-Git-Tag: REL9_5_ALPHA1~822
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4eaafa045362298adfe61fdd83b47b22211c75d1;p=postgresql

Remove dead code.

Commit 13629df changed metaphone() function to return an empty string on
empty input, but it left the old error message in place. It's now dead code.

Michael Paquier, per Coverity warning.
---

diff --git a/contrib/fuzzystrmatch/fuzzystrmatch.c b/contrib/fuzzystrmatch/fuzzystrmatch.c
index b48edb05ba..f9508a574f 100644
--- a/contrib/fuzzystrmatch/fuzzystrmatch.c
+++ b/contrib/fuzzystrmatch/fuzzystrmatch.c
@@ -280,11 +280,6 @@ metaphone(PG_FUNCTION_ARGS)
 				 errmsg("argument exceeds the maximum length of %d bytes",
 						MAX_METAPHONE_STRLEN)));
 
-	if (!(str_i_len > 0))
-		ereport(ERROR,
-				(errcode(ERRCODE_ZERO_LENGTH_CHARACTER_STRING),
-				 errmsg("argument is empty string")));
-
 	reqlen = PG_GETARG_INT32(1);
 	if (reqlen > MAX_METAPHONE_STRLEN)
 		ereport(ERROR,