From: Daniel Jasper Date: Sun, 13 Jan 2013 08:19:51 +0000 (+0000) Subject: Always put a space after ",". X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4e9008ac62b4c403c5c30724953664dcbb03d02e;p=clang Always put a space after ",". I am not aware of a case where that would be wrong. The specific case I am fixing are function parameters wrapped in parenthesis (e.g. in macros). Before: function(a,(b)); After: function(a, (b)); git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@172351 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Format/Format.cpp b/lib/Format/Format.cpp index 64a6224b0b..727e85fa4f 100644 --- a/lib/Format/Format.cpp +++ b/lib/Format/Format.cpp @@ -1149,6 +1149,8 @@ private: (Tok.is(tok::equal) || Tok.Parent->is(tok::equal))) return false; + if (Tok.Parent->is(tok::comma)) + return true; if (Tok.Type == TT_IncludePath) return Tok.is(tok::less) || Tok.is(tok::string_literal); if (Tok.Type == TT_CtorInitializerColon || Tok.Type == TT_ObjCBlockLParen) diff --git a/unittests/Format/FormatTest.cpp b/unittests/Format/FormatTest.cpp index 984732571e..a46c9b685b 100644 --- a/unittests/Format/FormatTest.cpp +++ b/unittests/Format/FormatTest.cpp @@ -121,6 +121,7 @@ TEST_F(FormatTest, FormatsNestedBlockStatements) { TEST_F(FormatTest, FormatsNestedCall) { verifyFormat("Method(f1, f2(f3));"); verifyFormat("Method(f1(f2, f3()));"); + verifyFormat("Method(f1(f2, (f3())));"); } //===----------------------------------------------------------------------===//