From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Mon, 16 May 2016 17:00:31 +0000 (-0600)
Subject: Use O_NOCTTY when opening a tty.
X-Git-Tag: SUDO_1_8_17^2~53
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4e6b6fd0fa508672ef0d7f4ba2aebe31046762a6;p=sudo

Use O_NOCTTY when opening a tty.
---

diff --git a/src/selinux.c b/src/selinux.c
index f0b9fbc02..096ff747e 100644
--- a/src/selinux.c
+++ b/src/selinux.c
@@ -160,7 +160,7 @@ relabel_tty(const char *ttyn, int ptyfd)
 
     /* If sudo is not allocating a pty for the command, open current tty. */
     if (ptyfd == -1) {
-	se_state.ttyfd = open(ttyn, O_RDWR|O_NONBLOCK);
+	se_state.ttyfd = open(ttyn, O_RDWR|O_NOCTTY|O_NONBLOCK);
 	if (se_state.ttyfd == -1) {
 	    sudo_warn(U_("unable to open %s, not relabeling tty"), ttyn);
 	    goto bad;
@@ -208,7 +208,7 @@ relabel_tty(const char *ttyn, int ptyfd)
     } else {
 	/* Re-open tty to get new label and reset std{in,out,err} */
 	close(se_state.ttyfd);
-	se_state.ttyfd = open(ttyn, O_RDWR|O_NONBLOCK);
+	se_state.ttyfd = open(ttyn, O_RDWR|O_NOCTTY|O_NONBLOCK);
 	if (se_state.ttyfd == -1) {
 	    sudo_warn(U_("unable to open %s"), ttyn);
 	    goto bad;