From: Todd C. Miller Date: Thu, 4 May 2017 18:25:51 +0000 (-0600) Subject: In check_input() when switch()ing on the return value of read(), X-Git-Tag: SUDO_1_8_20^2~9 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4e67ac56bd346152903cf023d5b2fe712eb99306;p=sudo In check_input() when switch()ing on the return value of read(), use the default label instead of 1 for the success case. It is only reading a single byte so the two are equivalent but it reads better using default. --- diff --git a/plugins/sudoers/sudoreplay.c b/plugins/sudoers/sudoreplay.c index 6f83c3255..11e24e9f9 100644 --- a/plugins/sudoers/sudoreplay.c +++ b/plugins/sudoers/sudoreplay.c @@ -1136,7 +1136,7 @@ check_input(int fd, int what, void *v) case 0: /* Ignore EOF. */ break; - case 1: + default: if (paused) { /* Any key will unpause, event is finished. */ /* XXX - pause time could be less than timeout */