From: Jordan Lee <jordan@transmissionbt.com>
Date: Thu, 17 Feb 2011 07:10:20 +0000 (+0000)
Subject: (trunk libT) #3767 "rarest first policy" -- remove some debugging code.
X-Git-Tag: 2.30b1~356
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4e608384347267bf256228e5ec28b5cbf21086a7;p=transmission

(trunk libT) #3767 "rarest first policy" -- remove some debugging code.

My initial thinking was to let nightly users test this out, but it's not necessary.
---

diff --git a/libtransmission/peer-msgs.c b/libtransmission/peer-msgs.c
index d1e741ced..826682bc4 100644
--- a/libtransmission/peer-msgs.c
+++ b/libtransmission/peer-msgs.c
@@ -171,7 +171,6 @@ struct tr_incoming
  */
 struct tr_peermsgs
 {
-    tr_bool         got_a_bitfield_or_have_all_or_have_none;
     tr_bool         peerSupportsPex;
     tr_bool         peerSupportsMetadataXfer;
     tr_bool         clientSentLtepHandshake;
@@ -1455,8 +1454,6 @@ readBtMessage( tr_peermsgs * msgs, struct evbuffer * inbuf, size_t inlen )
             const size_t bitCount = tr_torrentHasMetadata( msgs->torrent )
                                   ? msgs->torrent->info.pieceCount
                                   : msglen * 8;
-assert( !msgs->got_a_bitfield_or_have_all_or_have_none );
-msgs->got_a_bitfield_or_have_all_or_have_none = TRUE;
             dbgmsg( msgs, "got a bitfield" );
             tr_bitsetReserve( &msgs->peer->have, bitCount );
             tr_peerIoReadBytes( msgs->peer->io, inbuf,
@@ -1537,8 +1534,6 @@ msgs->got_a_bitfield_or_have_all_or_have_none = TRUE;
         case BT_FEXT_HAVE_ALL:
             dbgmsg( msgs, "Got a BT_FEXT_HAVE_ALL" );
             if( fext ) {
-assert( !msgs->got_a_bitfield_or_have_all_or_have_none );
-msgs->got_a_bitfield_or_have_all_or_have_none = TRUE;
                 tr_bitsetSetHaveAll( &msgs->peer->have );
                 fireClientGotHaveAll( msgs );
                 updatePeerProgress( msgs );
@@ -1551,8 +1546,6 @@ msgs->got_a_bitfield_or_have_all_or_have_none = TRUE;
         case BT_FEXT_HAVE_NONE:
             dbgmsg( msgs, "Got a BT_FEXT_HAVE_NONE" );
             if( fext ) {
-assert( !msgs->got_a_bitfield_or_have_all_or_have_none );
-msgs->got_a_bitfield_or_have_all_or_have_none = TRUE;
                 tr_bitsetSetHaveNone( &msgs->peer->have );
                 fireClientGotHaveNone( msgs );
                 updatePeerProgress( msgs );