From: Jardel Weyrich <jweyrich@gmail.com>
Date: Tue, 29 Dec 2009 18:19:24 +0000 (-0200)
Subject: Adjusted fcntl() retval comparison on evutil_make_socket_nonblocking().
X-Git-Tag: release-2.0.4-alpha~103
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4df7dbcbdfc9bf169f70b3e74e0a3ec824065bf3;p=libevent

Adjusted fcntl() retval comparison on evutil_make_socket_nonblocking().

Apparently, a successful return value on F_SETFL is "anything but
-1".
---

diff --git a/evutil.c b/evutil.c
index 800e40b2..3beb4bf7 100644
--- a/evutil.c
+++ b/evutil.c
@@ -187,11 +187,11 @@ evutil_make_socket_nonblocking(evutil_socket_t fd)
 	{
 		long flags;
 		if ((flags = fcntl(fd, F_GETFL, NULL)) < 0) {
-			event_warn("fcntl(F_GETFL)");
+			event_warn("fcntl(%d, F_GETFL)", fd);
 			return -1;
 		}
-		if (fcntl(fd, F_SETFL, flags | O_NONBLOCK) < 0) {
-			event_warn("fcntl(O_NONBLOCK)");
+		if (fcntl(fd, F_SETFL, flags | O_NONBLOCK) == -1) {
+			event_warn("fcntl(%d, F_SETFL)", fd);
 			return -1;
 		}
 	}