From: Jonas Devlieghere <jonas@devlieghere.com>
Date: Thu, 26 Jul 2018 14:16:19 +0000 (+0000)
Subject: [test] Disable dsymutil update test on windows
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4dcaa89c887214576bf03ab0fe4fbb5ee045c873;p=llvm

[test] Disable dsymutil update test on windows

Apparently, the issue with dsymutil update functionality on Windows was
that Windows doesn't like dsymutil renaming files that have open handles
to them. This disables the new accelerator test and updates the comment
in the other two test.

We should be able to enable the tests again once we updated the
implementation to use TempFile::keep() to keep the temporary files in
MachOUtils.

A big thank you to Jeremy Morse from Sony for figuring this out and
bringing it to my attention.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@338030 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/test/tools/dsymutil/X86/accelerator.test b/test/tools/dsymutil/X86/accelerator.test
index 96fc58ee568..906b0e645cf 100644
--- a/test/tools/dsymutil/X86/accelerator.test
+++ b/test/tools/dsymutil/X86/accelerator.test
@@ -1,3 +1,7 @@
+UNSUPPORTED: system-windows
+Windows does not like renaming files that have open handles to them. We
+need to use TempFile::keep to move them in a portable way.
+
 RUN: dsymutil -accelerator=Dwarf -oso-prepend-path=%p/.. %p/../Inputs/basic.macho.x86_64 -o %t.dwarf.dSYM
 RUN: dsymutil -accelerator=Apple -oso-prepend-path=%p/.. %p/../Inputs/basic.macho.x86_64 -o %t.apple.dSYM
 
diff --git a/test/tools/dsymutil/X86/update-one-CU.test b/test/tools/dsymutil/X86/update-one-CU.test
index 0759334a62e..5d36ce7135f 100644
--- a/test/tools/dsymutil/X86/update-one-CU.test
+++ b/test/tools/dsymutil/X86/update-one-CU.test
@@ -1,5 +1,6 @@
 UNSUPPORTED: system-windows
-Remove UNSUPPORTED once we figure out why this fails on Windows.
+Windows does not like renaming files that have open handles to them. We
+need to use TempFile::keep to move them in a portable way.
 
 RUN: dsymutil -oso-prepend-path=%p/.. %p/../Inputs/objc.macho.x86_64 -o %t.dSYM
 RUN: dsymutil -update %t.dSYM
diff --git a/test/tools/dsymutil/X86/update.test b/test/tools/dsymutil/X86/update.test
index 93e9b3617a6..cbfff63d6a8 100644
--- a/test/tools/dsymutil/X86/update.test
+++ b/test/tools/dsymutil/X86/update.test
@@ -1,5 +1,6 @@
 UNSUPPORTED: system-windows
-Remove UNSUPPORTED once we figure out why this fails on Windows.
+Windows does not like renaming files that have open handles to them. We
+need to use TempFile::keep to move them in a portable way.
 
 RUN: rm -rf %t.dir
 RUN: mkdir -p %t.dir