From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Wed, 10 Apr 2019 10:23:49 +0000 (+0200)
Subject: dnsdist: Use initializer list for ConnectionInfo
X-Git-Tag: dnsdist-1.4.0-alpha1~2^2~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4d1d0ef693fc605d201c44b899e1ace719bffc6d;p=pdns

dnsdist: Use initializer list for ConnectionInfo

Reported by cppcheck.
---

diff --git a/pdns/dnsdist-tcp.cc b/pdns/dnsdist-tcp.cc
index 878f056a0..1c51cdc16 100644
--- a/pdns/dnsdist-tcp.cc
+++ b/pdns/dnsdist-tcp.cc
@@ -209,12 +209,9 @@ struct ConnectionInfo
   ConnectionInfo(ClientState* cs_): cs(cs_), fd(-1)
   {
   }
-  ConnectionInfo(ConnectionInfo&& rhs)
+  ConnectionInfo(ConnectionInfo&& rhs): remote(rhs.remote), cs(rhs.cs), fd(rhs.fd)
   {
-    remote = rhs.remote;
-    cs = rhs.cs;
     rhs.cs = nullptr;
-    fd = rhs.fd;
     rhs.fd = -1;
   }