From: Tom Lane Date: Wed, 22 Jun 2005 21:14:31 +0000 (+0000) Subject: Make REINDEX DATABASE do what one would expect, namely reindex all indexes X-Git-Tag: REL8_1_0BETA1~490 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4cc7a93d220644ae068ce2639b961db6764a68f6;p=postgresql Make REINDEX DATABASE do what one would expect, namely reindex all indexes in the database. The old behavior (reindex system catalogs only) is now available as REINDEX SYSTEM. I did not add the complementary REINDEX USER case since there did not seem to be consensus for this, but it would be trivial to add later. Per recent discussions. --- diff --git a/doc/src/sgml/maintenance.sgml b/doc/src/sgml/maintenance.sgml index d68cd817c3..b9ce518554 100644 --- a/doc/src/sgml/maintenance.sgml +++ b/doc/src/sgml/maintenance.sgml @@ -1,5 +1,5 @@ @@ -468,8 +468,7 @@ HINT: Stop the postmaster and use a standalone backend to VACUUM in "mydb". In some situations it is worthwhile to rebuild indexes periodically - with the REINDEX command. (There is also - contrib/reindexdb which can reindex an entire database.) + with the REINDEX command. However, PostgreSQL 7.4 has substantially reduced the need for this activity compared to earlier releases. diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml index 9579b95e23..4bb6b9ff75 100644 --- a/doc/src/sgml/ref/reindex.sgml +++ b/doc/src/sgml/ref/reindex.sgml @@ -1,5 +1,5 @@ @@ -20,7 +20,7 @@ PostgreSQL documentation -REINDEX { DATABASE | TABLE | INDEX } name [ FORCE ] +REINDEX { INDEX | TABLE | DATABASE | SYSTEM } name [ FORCE ] @@ -28,7 +28,7 @@ REINDEX { DATABASE | TABLE | INDEX } nameDescription - REINDEX rebuilds an index based on the data + REINDEX rebuilds an index using the data stored in the index's table, replacing the old copy of the index. There are two main reasons to use REINDEX: @@ -63,12 +63,10 @@ REINDEX { DATABASE | TABLE | INDEX } name - DATABASE + INDEX - Recreate all system indexes of a specified database. Indexes on - user tables are not processed. Also, indexes on shared system - catalogs are skipped except in stand-alone mode (see below). + Recreate the specified index. @@ -77,17 +75,30 @@ REINDEX { DATABASE | TABLE | INDEX } nameTABLE - Recreate all indexes of a specified table. If the table has a + Recreate all indexes of the specified table. If the table has a secondary TOAST table, that is reindexed as well. - INDEX + DATABASE - Recreate a specified index. + Recreate all indexes within the current database. + Indexes on shared system catalogs are skipped except in stand-alone mode + (see below). + + + + + + SYSTEM + + + Recreate all indexes on system catalogs within the current database. + Indexes on user tables are not processed. Also, indexes on shared + system catalogs are skipped except in stand-alone mode (see below). @@ -96,10 +107,11 @@ REINDEX { DATABASE | TABLE | INDEX } namename - The name of the specific database, table, or index to be - reindexed. Table and index names may be schema-qualified. - Presently, REINDEX DATABASE can only reindex the current - database, so its parameter must match the current database's name. + The name of the specific index, table, or database to be + reindexed. Index and table names may be schema-qualified. + Presently, REINDEX DATABASE and REINDEX SYSTEM + can only reindex the current database, so their parameter must match + the current database's name. @@ -139,10 +151,10 @@ REINDEX { DATABASE | TABLE | INDEX } namePostgreSQL server with the option included on its command line. - Then, REINDEX DATABASE, + Then, REINDEX DATABASE, REINDEX SYSTEM, REINDEX TABLE, or REINDEX INDEX can be issued, depending on how much you want to reconstruct. If in - doubt, use REINDEX DATABASE to select + doubt, use REINDEX SYSTEM to select reconstruction of all system indexes in the database. Then quit the standalone server session and restart the regular server. See the reference page for more @@ -199,6 +211,21 @@ REINDEX { DATABASE | TABLE | INDEX } nameREINDEX does not. + + Reindexing a single index or table requires being the owner of that + index or table. Reindexing a database requires being the owner of + the database (note that the owner can therefore rebuild indexes of + tables owned by other users). Of course, superusers can always + reindex anything. + + + + Prior to PostgreSQL 8.1, REINDEX + DATABASE processed only system indexes, not all indexes as one would + expect from the name. This has been changed to reduce the surprise + factor. The old behavior is available as REINDEX SYSTEM. + + Prior to PostgreSQL 7.4, REINDEX TABLE did not automatically process TOAST tables, and so those had @@ -227,8 +254,8 @@ REINDEX INDEX my_index; - Rebuild all system indexes in a particular database, without trusting them - to be valid already: + Rebuild all indexes in a particular database, without trusting the + system indexes to be valid already: $ export PGOPTIONS="-P" diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c index 07adceb022..6bfa8a04e2 100644 --- a/src/backend/commands/indexcmds.c +++ b/src/backend/commands/indexcmds.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.132 2005/06/21 00:35:05 neilc Exp $ + * $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.133 2005/06/22 21:14:29 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -898,10 +898,10 @@ RemoveIndex(RangeVar *relation, DropBehavior behavior) /* * ReindexIndex - * Recreate an index. + * Recreate a specific index. */ void -ReindexIndex(RangeVar *indexRelation, bool force /* currently unused */ ) +ReindexIndex(RangeVar *indexRelation) { Oid indOid; HeapTuple tuple; @@ -931,10 +931,10 @@ ReindexIndex(RangeVar *indexRelation, bool force /* currently unused */ ) /* * ReindexTable - * Recreate indexes of a table. + * Recreate all indexes of a table (and of its toast table, if any) */ void -ReindexTable(RangeVar *relation, bool force /* currently unused */ ) +ReindexTable(RangeVar *relation) { Oid heapOid; HeapTuple tuple; @@ -981,8 +981,7 @@ ReindexTable(RangeVar *relation, bool force /* currently unused */ ) * separate transaction, so we can release the lock on it right away. */ void -ReindexDatabase(const char *dbname, bool force /* currently unused */ , - bool all) +ReindexDatabase(const char *databaseName, bool do_system, bool do_user) { Relation relationRelation; HeapScanDesc scan; @@ -992,23 +991,23 @@ ReindexDatabase(const char *dbname, bool force /* currently unused */ , List *relids = NIL; ListCell *l; - AssertArg(dbname); + AssertArg(databaseName); - if (strcmp(dbname, get_database_name(MyDatabaseId)) != 0) + if (strcmp(databaseName, get_database_name(MyDatabaseId)) != 0) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("can only reindex the currently open database"))); if (!pg_database_ownercheck(MyDatabaseId, GetUserId())) aclcheck_error(ACLCHECK_NOT_OWNER, ACL_KIND_DATABASE, - dbname); + databaseName); /* * We cannot run inside a user transaction block; if we were inside a * transaction, then our commit- and start-transaction-command calls * would not have the intended effect! */ - PreventTransactionChain((void *) dbname, "REINDEX DATABASE"); + PreventTransactionChain((void *) databaseName, "REINDEX DATABASE"); /* * Create a memory context that will survive forced transaction @@ -1028,9 +1027,12 @@ ReindexDatabase(const char *dbname, bool force /* currently unused */ , * before we process any other tables. This is critical because * reindexing itself will try to update pg_class. */ - old = MemoryContextSwitchTo(private_context); - relids = lappend_oid(relids, RelationRelationId); - MemoryContextSwitchTo(old); + if (do_system) + { + old = MemoryContextSwitchTo(private_context); + relids = lappend_oid(relids, RelationRelationId); + MemoryContextSwitchTo(old); + } /* * Scan pg_class to build a list of the relations we need to reindex. @@ -1047,9 +1049,15 @@ ReindexDatabase(const char *dbname, bool force /* currently unused */ , if (classtuple->relkind != RELKIND_RELATION) continue; - if (!all) /* only system tables? */ + /* Check user/system classification, and optionally skip */ + if (IsSystemClass(classtuple)) + { + if (!do_system) + continue; + } + else { - if (!IsSystemClass(classtuple)) + if (!do_user) continue; } diff --git a/src/backend/nodes/copyfuncs.c b/src/backend/nodes/copyfuncs.c index 2e0d8dbc1a..2ce9edac70 100644 --- a/src/backend/nodes/copyfuncs.c +++ b/src/backend/nodes/copyfuncs.c @@ -15,7 +15,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/nodes/copyfuncs.c,v 1.307 2005/06/17 22:32:43 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/nodes/copyfuncs.c,v 1.308 2005/06/22 21:14:29 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -2467,8 +2467,8 @@ _copyReindexStmt(ReindexStmt *from) COPY_SCALAR_FIELD(kind); COPY_NODE_FIELD(relation); COPY_STRING_FIELD(name); - COPY_SCALAR_FIELD(force); - COPY_SCALAR_FIELD(all); + COPY_SCALAR_FIELD(do_system); + COPY_SCALAR_FIELD(do_user); return newnode; } diff --git a/src/backend/nodes/equalfuncs.c b/src/backend/nodes/equalfuncs.c index a991cf5eed..e66ac81b75 100644 --- a/src/backend/nodes/equalfuncs.c +++ b/src/backend/nodes/equalfuncs.c @@ -18,7 +18,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/nodes/equalfuncs.c,v 1.244 2005/06/17 22:32:44 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/nodes/equalfuncs.c,v 1.245 2005/06/22 21:14:29 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -1372,8 +1372,8 @@ _equalReindexStmt(ReindexStmt *a, ReindexStmt *b) COMPARE_SCALAR_FIELD(kind); COMPARE_NODE_FIELD(relation); COMPARE_STRING_FIELD(name); - COMPARE_SCALAR_FIELD(force); - COMPARE_SCALAR_FIELD(all); + COMPARE_SCALAR_FIELD(do_system); + COMPARE_SCALAR_FIELD(do_user); return true; } diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y index d12fa9fa05..2603a65292 100644 --- a/src/backend/parser/gram.y +++ b/src/backend/parser/gram.y @@ -11,7 +11,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/parser/gram.y,v 2.495 2005/06/17 22:32:44 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/parser/gram.y,v 2.496 2005/06/22 21:14:29 tgl Exp $ * * HISTORY * AUTHOR DATE MAJOR EVENT @@ -400,7 +400,7 @@ static void doNegateFloat(Value *v); SERIALIZABLE SESSION SESSION_USER SET SETOF SHARE SHOW SIMILAR SIMPLE SMALLINT SOME STABLE START STATEMENT STATISTICS STDIN STDOUT STORAGE STRICT_P SUBSTRING SYMMETRIC - SYSID + SYSID SYSTEM_P TABLE TABLESPACE TEMP TEMPLATE TEMPORARY THEN TIME TIMESTAMP TO TOAST TRAILING TRANSACTION TREAT TRIGGER TRIM TRUE_P @@ -3641,8 +3641,9 @@ DropCastStmt: DROP CAST '(' Typename AS Typename ')' opt_drop_behavior * * QUERY: * - * REINDEX type [FORCE] [ALL] + * REINDEX type [FORCE] * + * FORCE no longer does anything, but we accept it for backwards compatibility *****************************************************************************/ ReindexStmt: @@ -3652,7 +3653,16 @@ ReindexStmt: n->kind = $2; n->relation = $3; n->name = NULL; - n->force = $4; + $$ = (Node *)n; + } + | REINDEX SYSTEM_P name opt_force + { + ReindexStmt *n = makeNode(ReindexStmt); + n->kind = OBJECT_DATABASE; + n->name = $3; + n->relation = NULL; + n->do_system = true; + n->do_user = false; $$ = (Node *)n; } | REINDEX DATABASE name opt_force @@ -3661,7 +3671,8 @@ ReindexStmt: n->kind = OBJECT_DATABASE; n->name = $3; n->relation = NULL; - n->force = $4; + n->do_system = true; + n->do_user = true; $$ = (Node *)n; } ; @@ -7915,6 +7926,7 @@ unreserved_keyword: | STDOUT | STORAGE | SYSID + | SYSTEM_P | STRICT_P | TABLESPACE | TEMP diff --git a/src/backend/parser/keywords.c b/src/backend/parser/keywords.c index 1e0c63a9ce..009cc2e7ba 100644 --- a/src/backend/parser/keywords.c +++ b/src/backend/parser/keywords.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/parser/keywords.c,v 1.157 2005/06/17 22:32:44 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/parser/keywords.c,v 1.158 2005/06/22 21:14:30 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -300,6 +300,7 @@ static const ScanKeyword ScanKeywords[] = { {"substring", SUBSTRING}, {"symmetric", SYMMETRIC}, {"sysid", SYSID}, + {"system", SYSTEM_P}, {"table", TABLE}, {"tablespace", TABLESPACE}, {"temp", TEMP}, diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c index f948b0f854..82bd8eafc1 100644 --- a/src/backend/tcop/utility.c +++ b/src/backend/tcop/utility.c @@ -10,7 +10,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/tcop/utility.c,v 1.237 2005/06/17 22:32:46 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/tcop/utility.c,v 1.238 2005/06/22 21:14:30 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -1011,13 +1011,14 @@ ProcessUtility(Node *parsetree, switch (stmt->kind) { case OBJECT_INDEX: - ReindexIndex(stmt->relation, stmt->force); + ReindexIndex(stmt->relation); break; case OBJECT_TABLE: - ReindexTable(stmt->relation, stmt->force); + ReindexTable(stmt->relation); break; case OBJECT_DATABASE: - ReindexDatabase(stmt->name, stmt->force, false); + ReindexDatabase(stmt->name, + stmt->do_system, stmt->do_user); break; default: elog(ERROR, "unrecognized object type: %d", diff --git a/src/bin/psql/common.c b/src/bin/psql/common.c index fed2275f46..741eb45f85 100644 --- a/src/bin/psql/common.c +++ b/src/bin/psql/common.c @@ -3,7 +3,7 @@ * * Copyright (c) 2000-2005, PostgreSQL Global Development Group * - * $PostgreSQL: pgsql/src/bin/psql/common.c,v 1.103 2005/06/17 22:32:47 tgl Exp $ + * $PostgreSQL: pgsql/src/bin/psql/common.c,v 1.104 2005/06/22 21:14:30 tgl Exp $ */ #include "postgres_fe.h" #include "common.h" @@ -1246,9 +1246,9 @@ command_no_begin(const char *query) return true; /* - * Note: these tests will match REINDEX TABLESPACE, which isn't really - * a valid command so we don't care much. The other five possible - * matches are correct. + * Note: these tests will match CREATE SYSTEM, DROP SYSTEM, and + * REINDEX TABLESPACE, which aren't really valid commands so we don't + * care much. The other six possible matches are correct. */ if ((wordlen == 6 && pg_strncasecmp(query, "create", 6) == 0) || (wordlen == 4 && pg_strncasecmp(query, "drop", 4) == 0) || @@ -1264,6 +1264,8 @@ command_no_begin(const char *query) if (wordlen == 8 && pg_strncasecmp(query, "database", 8) == 0) return true; + if (wordlen == 6 && pg_strncasecmp(query, "system", 6) == 0) + return true; if (wordlen == 10 && pg_strncasecmp(query, "tablespace", 10) == 0) return true; } diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c index 4700cc79bd..648ccadd4f 100644 --- a/src/bin/psql/tab-complete.c +++ b/src/bin/psql/tab-complete.c @@ -3,7 +3,7 @@ * * Copyright (c) 2000-2005, PostgreSQL Global Development Group * - * $PostgreSQL: pgsql/src/bin/psql/tab-complete.c,v 1.132 2005/06/21 00:48:33 neilc Exp $ + * $PostgreSQL: pgsql/src/bin/psql/tab-complete.c,v 1.133 2005/06/22 21:14:30 tgl Exp $ */ /*---------------------------------------------------------------------- @@ -1456,7 +1456,7 @@ psql_completion(char *text, int start, int end) else if (pg_strcasecmp(prev_wd, "REINDEX") == 0) { static const char *const list_REINDEX[] = - {"TABLE", "DATABASE", "INDEX", NULL}; + {"TABLE", "INDEX", "SYSTEM", "DATABASE", NULL}; COMPLETE_WITH_LIST(list_REINDEX); } @@ -1464,10 +1464,11 @@ psql_completion(char *text, int start, int end) { if (pg_strcasecmp(prev_wd, "TABLE") == 0) COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_tables, NULL); - else if (pg_strcasecmp(prev_wd, "DATABASE") == 0) - COMPLETE_WITH_QUERY(Query_for_list_of_databases); else if (pg_strcasecmp(prev_wd, "INDEX") == 0) COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_indexes, NULL); + else if (pg_strcasecmp(prev_wd, "SYSTEM") == 0 || + pg_strcasecmp(prev_wd, "DATABASE") == 0) + COMPLETE_WITH_QUERY(Query_for_list_of_databases); } /* SELECT */ diff --git a/src/include/commands/defrem.h b/src/include/commands/defrem.h index 359c5af700..1ae5649c13 100644 --- a/src/include/commands/defrem.h +++ b/src/include/commands/defrem.h @@ -7,7 +7,7 @@ * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/commands/defrem.h,v 1.64 2005/04/14 01:38:21 tgl Exp $ + * $PostgreSQL: pgsql/src/include/commands/defrem.h,v 1.65 2005/06/22 21:14:31 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -34,9 +34,10 @@ extern void DefineIndex(RangeVar *heapRelation, bool skip_build, bool quiet); extern void RemoveIndex(RangeVar *relation, DropBehavior behavior); -extern void ReindexIndex(RangeVar *indexRelation, bool force); -extern void ReindexTable(RangeVar *relation, bool force); -extern void ReindexDatabase(const char *databaseName, bool force, bool all); +extern void ReindexIndex(RangeVar *indexRelation); +extern void ReindexTable(RangeVar *relation); +extern void ReindexDatabase(const char *databaseName, + bool do_system, bool do_user); extern char *makeObjectName(const char *name1, const char *name2, const char *label); extern char *ChooseRelationName(const char *name1, const char *name2, diff --git a/src/include/nodes/parsenodes.h b/src/include/nodes/parsenodes.h index 993a240faa..e011bb9f97 100644 --- a/src/include/nodes/parsenodes.h +++ b/src/include/nodes/parsenodes.h @@ -7,7 +7,7 @@ * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/nodes/parsenodes.h,v 1.282 2005/06/17 22:32:49 tgl Exp $ + * $PostgreSQL: pgsql/src/include/nodes/parsenodes.h,v 1.283 2005/06/22 21:14:31 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -1758,8 +1758,8 @@ typedef struct ReindexStmt * OBJECT_DATABASE */ RangeVar *relation; /* Table or index to reindex */ const char *name; /* name of database to reindex */ - bool force; - bool all; + bool do_system; /* include system tables in database case */ + bool do_user; /* include user tables in database case */ } ReindexStmt; /* ----------------------