From: Brian Curtin <brian.curtin@gmail.com>
Date: Thu, 21 Oct 2010 14:48:22 +0000 (+0000)
Subject: Merged revisions 85774 via svnmerge from
X-Git-Tag: v2.7.1rc1~122
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4cc5403527e255bb4942b3ef8bca1b7f65781c29;p=python

Merged revisions 85774 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r85774 | brian.curtin | 2010-10-21 09:11:48 -0500 (Thu, 21 Oct 2010) | 7 lines

  Fix #10162: Add try/except around _winreg.OpenKey for keys that are
  unreadable by all users, e.g., Flash, Silverlight, and Java keys were
  causing errors.

  We don't currently have a way to grant/deny permissions for a key
  via winreg so there are no tests for this.
........
---

diff --git a/Lib/mimetypes.py b/Lib/mimetypes.py
index 816f6cdcde..4c054c961c 100644
--- a/Lib/mimetypes.py
+++ b/Lib/mimetypes.py
@@ -257,18 +257,19 @@ class MimeTypes:
         with _winreg.OpenKey(_winreg.HKEY_CLASSES_ROOT,
                              r'MIME\Database\Content Type') as mimedb:
             for ctype in enum_types(mimedb):
-                with _winreg.OpenKey(mimedb, ctype) as key:
-                    try:
-                        suffix, datatype = _winreg.QueryValueEx(key, 'Extension')
-                    except EnvironmentError:
-                        continue
-                    if datatype != _winreg.REG_SZ:
-                        continue
-                    try:
-                        suffix = suffix.encode(default_encoding) # omit in 3.x!
-                    except UnicodeEncodeError:
-                        continue
-                    self.add_type(ctype, suffix, strict)
+                try:
+                    with _winreg.OpenKey(mimedb, ctype) as key:
+                        suffix, datatype = _winreg.QueryValueEx(key,
+                                                                'Extension')
+                except EnvironmentError:
+                    continue
+                if datatype != _winreg.REG_SZ:
+                    continue
+                try:
+                    suffix = suffix.encode(default_encoding) # omit in 3.x!
+                except UnicodeEncodeError:
+                    continue
+                self.add_type(ctype, suffix, strict)
 
 
 def guess_type(url, strict=True):
diff --git a/Misc/NEWS b/Misc/NEWS
index f25664a67c..d25e25ec2f 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -60,6 +60,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #10163: Skip unreadable registry keys during mimetypes
+  initialization.
+
 - Issue #5117: Fixed root directory related issue on posixpath.relpath() and
   ntpath.relpath().