From: Kristján Valur Jónsson <kristjan@ccpgames.com>
Date: Tue, 4 Mar 2014 23:19:24 +0000 (+0000)
Subject: Fix pickling of rangeiter.  rangeiter_setstate would not allow setting it
X-Git-Tag: v3.4.1rc1~233^2~129^2~3
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4ca688edeb07de955e1ef67c11f0e327f12ffa6e;p=python

Fix pickling of rangeiter.  rangeiter_setstate would not allow setting it
to the exhausted state.
---

diff --git a/Lib/test/test_range.py b/Lib/test/test_range.py
index 2a13bfeabd..063f320bfe 100644
--- a/Lib/test/test_range.py
+++ b/Lib/test/test_range.py
@@ -379,6 +379,18 @@ class RangeTest(unittest.TestCase):
                 it = pickle.loads(d)
                 self.assertEqual(list(it), data[1:])
 
+    def test_exhausted_iterator_pickling(self):
+        r = range(20)
+        i = iter(r)
+        while True:
+            r = next(i)
+            if r == 19:
+                break
+        d = pickle.dumps(i)
+        i2 = pickle.loads(d)
+        self.assertEqual(list(i), [])
+        self.assertEqual(list(i2), [])
+
     def test_odd_bug(self):
         # This used to raise a "SystemError: NULL result without error"
         # because the range validation step was eating the exception
diff --git a/Objects/rangeobject.c b/Objects/rangeobject.c
index d790ca8f47..4b218b8961 100644
--- a/Objects/rangeobject.c
+++ b/Objects/rangeobject.c
@@ -1000,7 +1000,7 @@ rangeiter_setstate(rangeiterobject *r, PyObject *state)
     long index = PyLong_AsLong(state);
     if (index == -1 && PyErr_Occurred())
         return NULL;
-    if (index < 0 || index >= r->len) {
+    if (index < 0 || index > r->len) {
         PyErr_SetString(PyExc_ValueError, "index out of range");
         return NULL;
     }