From: Neal Norwitz <nnorwitz@gmail.com>
Date: Sun, 9 Apr 2006 04:07:39 +0000 (+0000)
Subject: Fix problem (not checking return result) reported by Coverity
X-Git-Tag: v2.5a2~386
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4c842a4db0e696f20017555d8f7933b9ffb8a4b3;p=python

Fix problem (not checking return result) reported by Coverity
---

diff --git a/Modules/_sqlite/cursor.c b/Modules/_sqlite/cursor.c
index b9ed56af00..c6b8c77a0f 100644
--- a/Modules/_sqlite/cursor.c
+++ b/Modules/_sqlite/cursor.c
@@ -455,6 +455,9 @@ PyObject* _query_execute(Cursor* self, int multiple, PyObject* args)
         Py_DECREF(second_argument);
 
         parameters_iter = PyObject_GetIter(parameters_list);
+        if (!parameters_iter) {
+            goto error;
+        }
     }
 
     if (self->statement != NULL) {
@@ -670,7 +673,7 @@ PyObject* _query_execute(Cursor* self, int multiple, PyObject* args)
 error:
     Py_XDECREF(operation_bytestr);
     Py_XDECREF(parameters);
-    Py_DECREF(parameters_iter);
+    Py_XDECREF(parameters_iter);
     Py_XDECREF(parameters_list);
 
     if (PyErr_Occurred()) {