From: George Burgess IV Date: Mon, 20 Jun 2016 19:13:07 +0000 (+0000) Subject: [MemorySSA] Clean up unit tests a tiny bit. NFC. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4c758ff48799020f1550545d0e79243e5707ea1e;p=llvm [MemorySSA] Clean up unit tests a tiny bit. NFC. We recently made MemorySSA own the walker it creates. As a part of this, the MSSA test fixture was changed to have a `Walker*` instead of a `unique_ptr`. So, we no longer need to do `&*Walker` in order to get a `Walker*`. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@273189 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/unittests/Transforms/Utils/MemorySSA.cpp b/unittests/Transforms/Utils/MemorySSA.cpp index b59e4fbc55e..961fb62f808 100644 --- a/unittests/Transforms/Utils/MemorySSA.cpp +++ b/unittests/Transforms/Utils/MemorySSA.cpp @@ -88,7 +88,7 @@ TEST_F(MemorySSATest, RemoveMemoryAccess) { setupAnalyses(); MemorySSA &MSSA = Analyses->MSSA; - MemorySSAWalker *Walker = &*Analyses->Walker; + MemorySSAWalker *Walker = Analyses->Walker; // Before, the load will be a use of a phi. It should be // the same after. @@ -148,7 +148,7 @@ TEST_F(MemorySSATest, TestTripleStore) { setupAnalyses(); MemorySSA &MSSA = Analyses->MSSA; - MemorySSAWalker *Walker = &*Analyses->Walker; + MemorySSAWalker *Walker = Analyses->Walker; unsigned I = 0; for (StoreInst *V : {S1, S2, S3}) { @@ -180,7 +180,7 @@ TEST_F(MemorySSATest, TestStoreAndLoad) { setupAnalyses(); MemorySSA &MSSA = Analyses->MSSA; - MemorySSAWalker *Walker = &*Analyses->Walker; + MemorySSAWalker *Walker = Analyses->Walker; MemoryAccess *LoadClobber = Walker->getClobberingMemoryAccess(LI); EXPECT_EQ(LoadClobber, MSSA.getMemoryAccess(SI)); @@ -210,7 +210,7 @@ TEST_F(MemorySSATest, TestStoreDoubleQuery) { setupAnalyses(); MemorySSA &MSSA = Analyses->MSSA; - MemorySSAWalker *Walker = &*Analyses->Walker; + MemorySSAWalker *Walker = Analyses->Walker; MemoryAccess *StoreAccess = MSSA.getMemoryAccess(SI); MemoryLocation StoreLoc = MemoryLocation::get(SI);