From: Benjamin Peterson <benjamin@python.org>
Date: Sat, 15 Aug 2009 13:16:38 +0000 (+0000)
Subject: #6707 fix a crash with dir() on an uninitialized module
X-Git-Tag: v2.7a1~661
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4c6e8088f52c4a1d33ff529685512fd6ebe0d21a;p=python

#6707 fix a crash with dir() on an uninitialized module
---

diff --git a/Lib/test/test_module.py b/Lib/test/test_module.py
index 5bc33d46dd..80d440d215 100644
--- a/Lib/test/test_module.py
+++ b/Lib/test/test_module.py
@@ -11,6 +11,7 @@ class ModuleTests(unittest.TestCase):
         # and __doc__ is None
         foo = ModuleType.__new__(ModuleType)
         self.assertTrue(foo.__dict__ is None)
+        self.assertRaises(SystemError, dir, foo)
         try:
             s = foo.__name__
             self.fail("__name__ = %s" % repr(s))
diff --git a/Misc/NEWS b/Misc/NEWS
index 44db52cb7e..5c467aa658 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -12,6 +12,8 @@ What's New in Python 2.7 alpha 1
 Core and Builtins
 -----------------
 
+- Issue #6707: dir() on an uninitialized module caused a crash.
+
 - Issue #6540: Fixed crash for bytearray.translate() with invalid parameters.
 
 - Issue #6573: set.union() stopped processing inputs if an instance of self
diff --git a/Objects/object.c b/Objects/object.c
index 0191ebe61d..3c7facb4c3 100644
--- a/Objects/object.c
+++ b/Objects/object.c
@@ -1810,9 +1810,11 @@ _specialized_dir_module(PyObject *obj)
 		if (PyDict_Check(dict))
 			result = PyDict_Keys(dict);
 		else {
-			PyErr_Format(PyExc_TypeError,
-				     "%.200s.__dict__ is not a dictionary",
-				     PyModule_GetName(obj));
+			char *name = PyModule_GetName(obj);
+			if (name)
+				PyErr_Format(PyExc_TypeError,
+					     "%.200s.__dict__ is not a dictionary",
+					     name);
 		}
 	}