From: Serhiy Storchaka <storchaka@gmail.com>
Date: Sat, 14 Feb 2015 21:17:13 +0000 (+0200)
Subject: Issue #17753: Skip test_zipfile tests which require write access to test
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4c2bada216b11d2a1af0e570f113ce529fb624ce;p=python

Issue #17753: Skip test_zipfile tests which require write access to test
and email.test.
---

diff --git a/Lib/test/test_zipfile.py b/Lib/test/test_zipfile.py
index f567c78ad8..71c6605829 100644
--- a/Lib/test/test_zipfile.py
+++ b/Lib/test/test_zipfile.py
@@ -775,7 +775,12 @@ class TestZip64InSmallFiles(unittest.TestCase):
 
 
 class PyZipFileTests(unittest.TestCase):
+    def requiresWriteAccess(self, path):
+        if not os.access(path, os.W_OK):
+            self.skipTest('requires write access to the installed location')
+
     def test_write_pyfile(self):
+        self.requiresWriteAccess(os.path.dirname(__file__))
         with zipfile.PyZipFile(TemporaryFile(), "w") as zipfp:
             fn = __file__
             if fn.endswith('.pyc') or fn.endswith('.pyo'):
@@ -803,6 +808,7 @@ class PyZipFileTests(unittest.TestCase):
     def test_write_python_package(self):
         import email
         packagedir = os.path.dirname(email.__file__)
+        self.requiresWriteAccess(packagedir)
 
         with zipfile.PyZipFile(TemporaryFile(), "w") as zipfp:
             zipfp.writepy(packagedir)