From: Jim Jagielski Date: Mon, 2 Dec 2013 12:18:19 +0000 (+0000) Subject: Merge r1544820 from trunk: X-Git-Tag: 2.4.8~363 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4bea5d7adc2b164f40ab1747224b247f8c95246c;p=apache Merge r1544820 from trunk: mod_lua: Fix compiler warning by using correct APR_SIZE_T_FMT and APR_OFF_T_FMT format macro in debug logging. Submitted by: rjung Reviewed/backported by: jim NOTE: Not sure about CHANGES... is there a BUGZ on this? In general, CHANGES is for userland visible changes or BUGZ bug fixes, and not sure if this really applies here. But it's OK if someone wants to add something to CHANGES. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1546976 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/STATUS b/STATUS index 8f90ad21b0..b372b26deb 100644 --- a/STATUS +++ b/STATUS @@ -98,11 +98,6 @@ RELEASE SHOWSTOPPERS: PATCHES ACCEPTED TO BACKPORT FROM TRUNK: [ start all new proposals below, under PATCHES PROPOSED. ] - * mod_lua: Fix compiler warning by using correct APR_SIZE_T_FMT and APR_OFF_T_FMT - format macro in debug logging. - trunk patch: https://svn.apache.org/viewvc?view=revision&revision=1544820 - 2.4.x patch: trunk patch works, add CHANGES - +1: rjung, jailletc36, trawick PATCHES PROPOSED TO BACKPORT FROM TRUNK: [ New proposals should be added at the end of the list ] diff --git a/modules/lua/lua_request.c b/modules/lua/lua_request.c index 8dce13cc22..dd1e552fc6 100644 --- a/modules/lua/lua_request.c +++ b/modules/lua/lua_request.c @@ -2098,7 +2098,7 @@ static int lua_websocket_read(lua_State *L) } } ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, - "Websocket: Reading %lu (%s) bytes, masking is %s. %s", + "Websocket: Reading %" APR_SIZE_T_FMT " (%s) bytes, masking is %s. %s", plen, (payload >= 126) ? "extra payload" : "no extra payload", mask ? "on" : "off", @@ -2133,14 +2133,14 @@ static int lua_websocket_read(lua_State *L) } } ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r, - "Websocket: Frame contained %lu bytes, pushed to Lua stack", + "Websocket: Frame contained %" APR_OFF_T_FMT " bytes, pushed to Lua stack", at); } else { rv = lua_websocket_readbytes(r->connection, buffer, remaining); ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r, - "Websocket: SSL Frame contained %lu bytes, "\ + "Websocket: SSL Frame contained %" APR_SIZE_T_FMT " bytes, "\ "pushed to Lua stack", remaining); } @@ -2280,7 +2280,7 @@ static int lua_websocket_ping(lua_State *L) } if (plen > 0) { ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r, - "Websocket: Reading %lu bytes of PONG", plen); + "Websocket: Reading %" APR_SIZE_T_FMT " bytes of PONG", plen); return 1; } if (mask) {