From: Victor Stinner <victor.stinner@gmail.com>
Date: Fri, 19 Aug 2016 13:11:56 +0000 (+0200)
Subject: Fix a clang warning in grammar.c
X-Git-Tag: v3.6.0b1~666
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4bb31e90f0ec07188183e318a7c86f81c2023ed0;p=python

Fix a clang warning in grammar.c

Clang is smarter than GCC and emits a warning for dead code after a function
declared with __attribute__((__noreturn__)) (Py_FatalError).
---

diff --git a/Parser/grammar.c b/Parser/grammar.c
index b598294a4a..e2cce28a8d 100644
--- a/Parser/grammar.c
+++ b/Parser/grammar.c
@@ -122,7 +122,13 @@ findlabel(labellist *ll, int type, const char *str)
     }
     fprintf(stderr, "Label %d/'%s' not found\n", type, str);
     Py_FatalError("grammar.c:findlabel()");
+
+    /* Py_FatalError() is declared with __attribute__((__noreturn__)).
+       GCC emits a warning without "return 0;" (compiler bug!), but Clang is
+       smarter and emits a warning on the return... */
+#ifndef __clang__
     return 0; /* Make gcc -Wall happy */
+#endif
 }
 
 /* Forward */