From: Zackery Spytz <zspytz@gmail.com>
Date: Sat, 29 Sep 2018 05:48:46 +0000 (-0600)
Subject: Fix incorrect error handling in _pickle.Unpickler.__init__() (GH-9630)
X-Git-Tag: v3.8.0a1~862
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4b430e5f6954ef4b248e95bfb4087635dcdefc6d;p=python

Fix incorrect error handling in _pickle.Unpickler.__init__() (GH-9630)

_pickle.Unpickler.__init__() should return -1 if Pdata_New() fails, not 1.
---

diff --git a/Modules/_pickle.c b/Modules/_pickle.c
index 3588e33f09..0e3bd225db 100644
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -6792,7 +6792,7 @@ _pickle_Unpickler___init___impl(UnpicklerObject *self, PyObject *file,
 
     self->stack = (Pdata *)Pdata_New();
     if (self->stack == NULL)
-        return 1;
+        return -1;
 
     self->memo_size = 32;
     self->memo = _Unpickler_NewMemo(self->memo_size);