From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Fri, 5 Aug 2022 04:16:27 +0000 (-0700)
Subject: expr: remove dereferencing and parens around calling 'Exdisc_t.binaryf'
X-Git-Tag: 5.0.1~18^2~7
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4b3291ac22ac290255c3c6aa9b24b98b75f40704;p=graphviz

expr: remove dereferencing and parens around calling 'Exdisc_t.binaryf'

The compiler does not need to be explicitly told how to call through a function
pointer.
---

diff --git a/lib/expr/exgram.h b/lib/expr/exgram.h
index f7c644005..57a17d88e 100644
--- a/lib/expr/exgram.h
+++ b/lib/expr/exgram.h
@@ -1014,7 +1014,7 @@ exclose(Expr_t* p, int all)
 static void
 checkBinary(Expr_t * p, Exnode_t * l, Exnode_t * ex, Exnode_t * r) 
 {
-	if ((*p->disc->binaryf) (l, ex, r, 1) < 0) {
+	if (p->disc->binaryf(l, ex, r, 1) < 0) {
 	    if (r)
 		exerror
 		    ("cannot apply operator %s to expressions of types %s and %s",