From: nekral-guest <nekral-guest@5a98b0ae-9ef6-0310-add3-de5d479b70d7>
Date: Mon, 31 Dec 2007 14:37:24 +0000 (+0000)
Subject: Avoid assignments in comparisons.
X-Git-Tag: 4.1.1~206
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4af02cb0834063c92040a20a0fe54c758530d42f;p=shadow

Avoid assignments in comparisons.
---

diff --git a/src/chfn.c b/src/chfn.c
index 6607cb09..3baea8f8 100644
--- a/src/chfn.c
+++ b/src/chfn.c
@@ -210,7 +210,8 @@ static char *copy_field (char *in, char *out, char *extra)
 	char *cp = NULL;
 
 	while (NULL != in) {
-		if ((cp = strchr (in, ',')) != NULL) {
+		cp = strchr (in, ',');
+		if (NULL != cp) {
 			*cp++ = '\0';
 		}