From: Saleem Abdulrasool Date: Wed, 22 Oct 2014 02:37:29 +0000 (+0000) Subject: Driver: rename Windows to MSVCToolChain X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4a63958cbdd83f71133ba4ffbddcac9b2ff41740;p=clang Driver: rename Windows to MSVCToolChain This renames the Windows toolchain to MSVCToolChain. This is a preparatory step for adding a CrossWindowsToolChain which uses clang/libc++/(ld/lld) without the standard GCC toolchain lookup. NFC. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@220362 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Driver/CMakeLists.txt b/lib/Driver/CMakeLists.txt index 33db5e9a9e..dfc6e091f9 100644 --- a/lib/Driver/CMakeLists.txt +++ b/lib/Driver/CMakeLists.txt @@ -10,12 +10,12 @@ add_clang_library(clangDriver DriverOptions.cpp Job.cpp Multilib.cpp + MSVCToolChain.cpp Phases.cpp SanitizerArgs.cpp Tool.cpp ToolChain.cpp ToolChains.cpp - WindowsToolChain.cpp Tools.cpp Types.cpp diff --git a/lib/Driver/Driver.cpp b/lib/Driver/Driver.cpp index ccefbd8c36..9fea2f405c 100644 --- a/lib/Driver/Driver.cpp +++ b/lib/Driver/Driver.cpp @@ -2041,7 +2041,7 @@ const ToolChain &Driver::getToolChain(const ArgList &Args, break; case llvm::Triple::MSVC: case llvm::Triple::UnknownEnvironment: - TC = new toolchains::Windows(*this, Target, Args); + TC = new toolchains::MSVCToolChain(*this, Target, Args); break; } break; diff --git a/lib/Driver/WindowsToolChain.cpp b/lib/Driver/MSVCToolChain.cpp similarity index 93% rename from lib/Driver/WindowsToolChain.cpp rename to lib/Driver/MSVCToolChain.cpp index 5b54ca6807..882c783071 100644 --- a/lib/Driver/WindowsToolChain.cpp +++ b/lib/Driver/MSVCToolChain.cpp @@ -38,42 +38,42 @@ using namespace clang::driver::toolchains; using namespace clang; using namespace llvm::opt; -Windows::Windows(const Driver &D, const llvm::Triple& Triple, - const ArgList &Args) +MSVCToolChain::MSVCToolChain(const Driver &D, const llvm::Triple& Triple, + const ArgList &Args) : ToolChain(D, Triple, Args) { } -Tool *Windows::buildLinker() const { +Tool *MSVCToolChain::buildLinker() const { return new tools::visualstudio::Link(*this); } -Tool *Windows::buildAssembler() const { +Tool *MSVCToolChain::buildAssembler() const { if (getTriple().isOSBinFormatMachO()) return new tools::darwin::Assemble(*this); getDriver().Diag(clang::diag::err_no_external_assembler); return nullptr; } -bool Windows::IsIntegratedAssemblerDefault() const { +bool MSVCToolChain::IsIntegratedAssemblerDefault() const { return true; } -bool Windows::IsUnwindTablesDefault() const { +bool MSVCToolChain::IsUnwindTablesDefault() const { // Emit unwind tables by default on Win64. All non-x86_32 Windows platforms // such as ARM and PPC actually require unwind tables, but LLVM doesn't know // how to generate them yet. return getArch() == llvm::Triple::x86_64; } -bool Windows::isPICDefault() const { +bool MSVCToolChain::isPICDefault() const { return getArch() == llvm::Triple::x86_64; } -bool Windows::isPIEDefault() const { +bool MSVCToolChain::isPIEDefault() const { return false; } -bool Windows::isPICDefaultForced() const { +bool MSVCToolChain::isPICDefaultForced() const { return getArch() == llvm::Triple::x86_64; } @@ -270,8 +270,8 @@ static bool getVisualStudioDir(std::string &path) { return false; } -void Windows::AddClangSystemIncludeArgs(const ArgList &DriverArgs, - ArgStringList &CC1Args) const { +void MSVCToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { if (DriverArgs.hasArg(options::OPT_nostdinc)) return; @@ -329,7 +329,7 @@ void Windows::AddClangSystemIncludeArgs(const ArgList &DriverArgs, addSystemIncludes(DriverArgs, CC1Args, Paths); } -void Windows::AddClangCXXStdlibIncludeArgs(const ArgList &DriverArgs, - ArgStringList &CC1Args) const { +void MSVCToolChain::AddClangCXXStdlibIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { // FIXME: There should probably be logic here to find libc++ on Windows. } diff --git a/lib/Driver/ToolChains.h b/lib/Driver/ToolChains.h index 291e9abc83..3504360233 100644 --- a/lib/Driver/ToolChains.h +++ b/lib/Driver/ToolChains.h @@ -727,10 +727,10 @@ public: bool isPICDefaultForced() const override; }; -class LLVM_LIBRARY_VISIBILITY Windows : public ToolChain { +class LLVM_LIBRARY_VISIBILITY MSVCToolChain : public ToolChain { public: - Windows(const Driver &D, const llvm::Triple &Triple, - const llvm::opt::ArgList &Args); + MSVCToolChain(const Driver &D, const llvm::Triple &Triple, + const llvm::opt::ArgList &Args); bool IsIntegratedAssemblerDefault() const override; bool IsUnwindTablesDefault() const override;