From: Greg Beaver <cellog@php.net>
Date: Wed, 23 Apr 2008 18:22:55 +0000 (+0000)
Subject: increase code coverage
X-Git-Tag: RELEASE_2_0_0b1~247
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4a0b06af8224353e482faf6f9c16d5f7284c7c1d;p=php

increase code coverage
---

diff --git a/ext/phar/tests/phar_isvalidpharfilename.phpt b/ext/phar/tests/phar_isvalidpharfilename.phpt
index f5b0c8d70e..32b5bef29e 100644
--- a/ext/phar/tests/phar_isvalidpharfilename.phpt
+++ b/ext/phar/tests/phar_isvalidpharfilename.phpt
@@ -72,6 +72,11 @@ var_dump(Phar::isValidPharFilename('myphar.phar'));
 var_dump(Phar::isValidPharFilename('myphar.phar', true));
 var_dump(Phar::isValidPharFilename('myphar.phar', false));
 
+echo "\ndir.phar.php\n";
+var_dump(Phar::isValidPharFilename('dir.phar.php'));
+var_dump(Phar::isValidPharFilename('dir.phar.php', true));
+var_dump(Phar::isValidPharFilename('dir.phar.php', false));
+
 ?>
 ===DONE===
 --CLEAN--
@@ -138,5 +143,10 @@ myphar.phar
 bool(true)
 bool(true)
 bool(false)
+
+dir.phar.php
+bool(true)
+bool(true)
+bool(false)
 ===DONE===
 
diff --git a/ext/phar/tests/phar_oo_001.phpt b/ext/phar/tests/phar_oo_001.phpt
index 616b2ec0ac..81d57d1bfc 100755
--- a/ext/phar/tests/phar_oo_001.phpt
+++ b/ext/phar/tests/phar_oo_001.phpt
@@ -5,6 +5,7 @@ Phar object: basics
 <?php if (!extension_loaded("spl")) die("skip SPL not available"); ?>
 --INI--
 phar.require_hash=0
+phar.readonly=0
 --FILE--
 <?php
 
@@ -30,6 +31,13 @@ catch (BadMethodCallException $e)
 {
 	var_dump($e->getMessage());
 }
+try {
+	$phar = new Phar('test.phar');
+	$phar->__construct('oops');
+} catch (BadMethodCallException $e)
+{
+	var_dump($e->getMessage());
+}
 
 ?>
 ===DONE===
@@ -42,4 +50,5 @@ __halt_compiler();
 string(5) "1.0.0"
 int(5)
 string(50) "Cannot call method on an uninitialized Phar object"
+string(29) "Cannot call constructor twice"
 ===DONE===