From: R David Murray <rdmurray@bitdance.com>
Date: Fri, 6 Sep 2013 17:08:08 +0000 (-0400)
Subject: #18852: Handle readline.__doc__ being None in site.py readline activation.
X-Git-Tag: v3.4.0a2~10
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4a0430166bdf9afd04b9e6bd00f43080bc57d00b;p=python

#18852: Handle readline.__doc__ being None in site.py readline activation.

Patch by Berker Peksag.
---

diff --git a/Lib/site.py b/Lib/site.py
index 77d198a55b..c4ea6f6adb 100644
--- a/Lib/site.py
+++ b/Lib/site.py
@@ -388,8 +388,9 @@ def enablerlcompleter():
             return
 
         # Reading the initialization (config) file may not be enough to set a
-        # completion key, so we set one first and then read the file
-        if 'libedit' in getattr(readline, '__doc__', ''):
+        # completion key, so we set one first and then read the file.
+        readline_doc = getattr(readline, '__doc__', '')
+        if readline_doc is not None and 'libedit' in readline_doc:
             readline.parse_and_bind('bind ^I rl_complete')
         else:
             readline.parse_and_bind('tab: complete')
diff --git a/Misc/NEWS b/Misc/NEWS
index 67788c911e..e235e7dfb0 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -56,6 +56,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #18852: Handle case of ``readline.__doc__`` being ``None`` in the new
+  readline activation code in ``site.py``.
+
 - Issue #18672: Fixed format specifiers for Py_ssize_t in debugging output in
   the _sre moduel.