From: Jeroen van Wolffelaar <jeroen@php.net>
Date: Fri, 3 Aug 2001 19:18:51 +0000 (+0000)
Subject: - Fix array_sum to switch to float on overflow. Fixes bug#12505
X-Git-Tag: PRE_ENGINE2_SPLIT~94
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=49c16290f383e4c821b13b791022e14a00cc7f34;p=php

- Fix array_sum to switch to float on overflow. Fixes bug#12505
---

diff --git a/ext/standard/array.c b/ext/standard/array.c
index a12a95e170..3a85caeb63 100644
--- a/ext/standard/array.c
+++ b/ext/standard/array.c
@@ -2809,6 +2809,7 @@ PHP_FUNCTION(array_sum)
 		 **entry;
 	int argc = ZEND_NUM_ARGS();
 	HashPosition pos;
+	double dval;
 	
 	if (argc != 1 || zend_get_parameters_ex(argc, &input) == FAILURE) {
 		WRONG_PARAM_COUNT;
@@ -2833,12 +2834,15 @@ PHP_FUNCTION(array_sum)
 		convert_scalar_to_number(*entry TSRMLS_CC);
 
 		if (Z_TYPE_PP(entry) == IS_LONG && Z_TYPE_P(return_value) == IS_LONG) {
-			Z_LVAL_P(return_value) += Z_LVAL_PP(entry);
-		} else {
-			convert_to_double(return_value);
-			convert_to_double_ex(entry);
-			Z_DVAL_P(return_value) += Z_DVAL_PP(entry);
+			dval = (double)Z_LVAL_P(return_value) + (double)Z_LVAL_PP(entry);
+			if ( (double)LONG_MIN <= dval && dval <= (double)LONG_MAX ) {
+				Z_LVAL_P(return_value) += Z_LVAL_PP(entry);
+				continue;
+			}
 		}
+		convert_to_double(return_value);
+		convert_to_double_ex(entry);
+		Z_DVAL_P(return_value) += Z_DVAL_PP(entry);
 	}
 }