From: Fred Drake Date: Fri, 5 Sep 1997 17:53:53 +0000 (+0000) Subject: Fix in trailing comment: PyDict_SetItemString() does *not* consume a reference X-Git-Tag: v1.5a4~228 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=49bb0e32a03c056a42df5c8d90347db19d3cb2d4;p=python Fix in trailing comment: PyDict_SetItemString() does *not* consume a reference count, PyList_SetItem() does. Very confusing! --- diff --git a/Include/object.h b/Include/object.h index 65e25bc7a5..b3f18d7af7 100644 --- a/Include/object.h +++ b/Include/object.h @@ -461,9 +461,8 @@ quickly. Thus, to retrieve an object and store it again, the caller must call Py_INCREF() explicitly. NOTE: functions that 'consume' a reference count like -PyDict_SetItemString() even -consume the reference if the object wasn't stored, to simplify error -handling. +PyList_SetItemString() even consume the reference if the object wasn't +stored, to simplify error handling. It seems attractive to make other functions that take an object as argument consume a reference count; however this may quickly get