From: Martin v. Löwis <martin@v.loewis.de>
Date: Sun, 27 Mar 2011 08:10:46 +0000 (+0200)
Subject: Fix short file name generation in bdist_msi.
X-Git-Tag: v2.7.2rc1~203
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=49b0ce06f01a27c98a61a1287ea1b8d40c0f2e51;p=python

Fix short file name generation in bdist_msi.
Patch by Christoph Gohlke.
Closes #7639.
---

diff --git a/Lib/msilib/__init__.py b/Lib/msilib/__init__.py
index 1aa0637ab8..d7a31c0b62 100644
--- a/Lib/msilib/__init__.py
+++ b/Lib/msilib/__init__.py
@@ -174,10 +174,10 @@ def add_tables(db, module):
 
 def make_id(str):
     #str = str.replace(".", "_") # colons are allowed
-    str = str.replace(" ", "_")
-    str = str.replace("-", "_")
-    if str[0] in string.digits:
-        str = "_"+str
+    for c in " -+~;":
+        str = str.replace(c, "_")
+    if str[0] in (string.digits + "."):
+        str = "_" + str
     assert re.match("^[A-Za-z_][A-Za-z0-9_.]*$", str), "FILE"+str
     return str
 
@@ -285,19 +285,28 @@ class Directory:
                         [(feature.id, component)])
 
     def make_short(self, file):
+        oldfile = file
+        file = file.replace('+', '_')
+        file = ''.join(c for c in file if not c in ' "/\[]:;=,')
         parts = file.split(".")
-        if len(parts)>1:
+        if len(parts) > 1:
+            prefix = "".join(parts[:-1]).upper()
             suffix = parts[-1].upper()
+            if not prefix:
+                prefix = suffix
+                suffix = None
         else:
+            prefix = file.upper()
             suffix = None
-        prefix = parts[0].upper()
-        if len(prefix) <= 8 and (not suffix or len(suffix)<=3):
+        if len(parts) < 3 and len(prefix) <= 8 and file == oldfile and (
+                                                not suffix or len(suffix) <= 3):
             if suffix:
                 file = prefix+"."+suffix
             else:
                 file = prefix
-            assert file not in self.short_names
         else:
+            file = None
+        if file is None or file in self.short_names:
             prefix = prefix[:6]
             if suffix:
                 suffix = suffix[:3]
diff --git a/Misc/NEWS b/Misc/NEWS
index 3c590aceea..f0b9a08486 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -51,6 +51,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #7639: Fix short file name generation in bdist_msi.
+
 - Issue #11666: let help() display named tuple attributes and methods
   that start with a leading underscore.