From: Cristian Morales Vega <cristian@samknows.com>
Date: Sun, 20 May 2018 11:11:55 +0000 (+1000)
Subject: buildsys: signals.c depends on signames.h
X-Git-Tag: v23.2~11
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4944e7a3b7a0103e88196cd9c936374f46f993c3;p=psmisc

buildsys: signals.c depends on signames.h

By explicitly specifying the dependency between signals.c and
signames.h.

BUILT_SOURCES only works with the standard targets, so if somebody tries
to build fuser directly he may end up with a build failure. What's
worse, he could do "make -j2 src/signames.h src/fuser" and he could end
up with a broken build using a only partially generated signames.h.

And that "somebody" was me when packaging killall in psmisc 22.21...
so it actually happens.

References:
 psmisc/psmisc!16
---

diff --git a/ChangeLog b/ChangeLog
index 6d5eaaa..1627765 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,6 @@
 Changes in 23.2
 ===============
+	* buildsys: signals.c depends on signames.h !16
 	* killall: look at all namespaces by default
 	* killall: Fix -INT option parsing #11
 	* killall: change to getopt_long without _only #12
diff --git a/Makefile.am b/Makefile.am
index d32ddde..d8c4619 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -89,6 +89,8 @@ src/signames.h: src/signames.c Makefile
 		grep '^{ 1,"HUP" },$$' $@ >/dev/null || \
 		  { rm -f $@; exit 1; }
 
+src/signals.c: src/signames.h
+
 install-exec-hook:
 		cd $(DESTDIR)$(bindir) && \
 			( [ -h pstree.x11 ]  || $(LN_S) pstree pstree.x11)