From: Victor Stinner <victor.stinner@gmail.com>
Date: Mon, 11 Dec 2017 12:57:12 +0000 (+0100)
Subject: bpo-32252: Fix faulthandler_suppress_crash_report() (#4794)
X-Git-Tag: v3.7.0a4~176
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=48d4dd974f0c8d47c54990eedd322b96b19c60ec;p=python

bpo-32252: Fix faulthandler_suppress_crash_report() (#4794)

Fix faulthandler_suppress_crash_report() used to prevent core dump files
when testing crashes. getrlimit() returns zero on success.
---

diff --git a/Misc/NEWS.d/next/Tests/2017-12-11-13-31-33.bpo-32252.YnFw7J.rst b/Misc/NEWS.d/next/Tests/2017-12-11-13-31-33.bpo-32252.YnFw7J.rst
new file mode 100644
index 0000000000..ee4c56bb73
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2017-12-11-13-31-33.bpo-32252.YnFw7J.rst
@@ -0,0 +1,2 @@
+Fix faulthandler_suppress_crash_report() used to prevent core dump files
+when testing crashes. getrlimit() returns zero on success.
diff --git a/Modules/faulthandler.c b/Modules/faulthandler.c
index 0e85cce132..baa2e91770 100644
--- a/Modules/faulthandler.c
+++ b/Modules/faulthandler.c
@@ -932,7 +932,7 @@ faulthandler_suppress_crash_report(void)
     struct rlimit rl;
 
     /* Disable creation of core dump */
-    if (getrlimit(RLIMIT_CORE, &rl) != 0) {
+    if (getrlimit(RLIMIT_CORE, &rl) == 0) {
         rl.rlim_cur = 0;
         setrlimit(RLIMIT_CORE, &rl);
     }