From: Ivan Maidanski <ivmai@mail.ru>
Date: Fri, 19 Oct 2012 03:12:09 +0000 (+0400)
Subject: Add comment for big local_mark_stack variables in mark.c
X-Git-Tag: gc7_4_0~193
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=48699f2ab6880c7b61d2f879f398e64c635a1473;p=gc

Add comment for big local_mark_stack variables in mark.c

* mark.c (LOCAL_MARK_STACK_SIZE): Fix letter case in comment.
* mark.c (GC_do_parallel_mark, GC_help_marker): Add comment about
local_mark_stack local variable size (some static analysis tools
issue warning about it).
* mark.c (GC_help_marker): Move local_mark_stack variable declaration
down to be the last one in the function.
---

diff --git a/mark.c b/mark.c
index 50be939a..91081b6e 100644
--- a/mark.c
+++ b/mark.c
@@ -890,7 +890,7 @@ GC_INNER word GC_mark_no = 0;
 
 #define LOCAL_MARK_STACK_SIZE HBLKSIZE
         /* Under normal circumstances, this is big enough to guarantee  */
-        /* We don't overflow half of it in a single call to             */
+        /* we don't overflow half of it in a single call to             */
         /* GC_mark_from.                                                */
 
 
@@ -1128,6 +1128,7 @@ STATIC void GC_mark_local(mse *local_mark_stack, int id)
 STATIC void GC_do_parallel_mark(void)
 {
     mse local_mark_stack[LOCAL_MARK_STACK_SIZE];
+                /* Note: local_mark_stack is quite big (up to 128 KiB). */
 
     GC_acquire_mark_lock();
     GC_ASSERT(I_HOLD_LOCK());
@@ -1164,8 +1165,9 @@ STATIC void GC_do_parallel_mark(void)
 /* We do not hold the GC lock, but the requestor does.  */
 GC_INNER void GC_help_marker(word my_mark_no)
 {
-    mse local_mark_stack[LOCAL_MARK_STACK_SIZE];
     unsigned my_id;
+    mse local_mark_stack[LOCAL_MARK_STACK_SIZE];
+                /* Note: local_mark_stack is quite big (up to 128 KiB). */
 
     if (!GC_parallel) return;